Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full Report Details for GWS.GMAIL.5.5 #294

Closed
adhilto opened this issue May 29, 2024 · 0 comments · Fixed by #394
Closed

Full Report Details for GWS.GMAIL.5.5 #294

adhilto opened this issue May 29, 2024 · 0 comments · Fixed by #394
Assignees
@snarve
Labels
bug This issue or pull request addresses broken functionality
Milestone
Coast

Comments

@adhilto
Copy link
Collaborator

adhilto commented May 29, 2024

🐛 Summary

Currently (as of #278), the report details for GWS.GMAIL.5.5 doesn't always show the full picture.

For example, after setting the action for encrypted attachments from untrusted senders, attachments with scripts from untrusted senders, and anomalous attachment types all to warning, the report just says:

[OU name]: Emails with encrypted attachments from untrusted senders are kept in the inbox.

Ideally it would report that all three settings are non-compliant, not just one of them. For example:

[OU name]: The action for encrypted attachments from untrusted senders is set to warning. The action for attachments with scripts from untrusted senders is set to warning. The action for anomalous attachment type is set to warning.

To reproduce

  1. Admin center -> Apps -> Google Workspace -> Gmail -> Safety -> Attachments -> Set the action for multiple categories to "Keep in inbox and show warning"
  2. Run ScubaGoggles. Note that only one category is reported in the report details column.

Expected behavior

All categories would be listed in the Report Details column.

Any helpful log output or screenshots

Refer to GWS.CHAT.7.1 for an example of how to implement Report Details messages like this in Rego.
@adhilto adhilto added the bug This issue or pull request addresses broken functionality label May 29, 2024
@adhilto adhilto added this to the Coast milestone May 29, 2024
@adhilto adhilto mentioned this issue May 29, 2024
Closed
@snarve snarve self-assigned this May 30, 2024
@snarve snarve mentioned this issue Sep 10, 2024
Merged
14 tasks
snarve added a commit that referenced this issue Sep 10, 2024
@snarve
[#294] Fix linter issues
e01df25
snarve added a commit that referenced this issue Sep 10, 2024
@snarve
[#294] Linter formatting
d3617a1
snarve added a commit that referenced this issue Sep 10, 2024
@snarve
[#294] More formatting
29c65ac
adhilto pushed a commit that referenced this issue Sep 11, 2024
@snarve
[#294, #295] Update Gmail policies 5 and 7 to include all instances o…
9a4bbc8 
…f spoofing and authentication settings that are not complaint (#394)

* [#295] Update policy 7

* [#295] Update policy 7 to handle multiple settings detailed report message

* [#295] Cleanup

* [#295] Update 7.6 and 5.5

* [#295] Update policy 5 and 7

* [#295] Format the report output

* [#295] Fix formatting for policy 7 and rename variables with more logical names

* [#295] Rename policy 5 and 7 variables and formatting updates

* [#295] Unit tests updated

* [#294] Fix linter issues

* [#294] Linter formatting

* [#294] More formatting

* [#295] Try different format for linter

* [#295] Remove if statement

* [#295] Use different assignment operator

* [#295] Update assignment operator for policy 5

* Linter fix

* More linter fixes

* Linter formatting

* Linter again

* Update array format

* Remove comma

* Remove array notation

* Replace assignment operator

* Refactor functions

* Typo fixed

* [#396] Updated the criticality for policy 5.5

* [#397] Update criticality for policy 7.6

* PR updates

* Remove typo

* Update message for setting

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snarve snarve

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
Coast
2 participants
@adhilto @snarve