Lineage pull request for: skeleton #12
Conversation
The pytest-dockerc plug is unmaintained and there is now a dependency issues with PyYAML because of the release of Cython v3 (which is itself a build dependency for PyYAML). After some research this seemed like the most similar package in terms of functionality to the package we are replacing. Although it is not a pytest plugin it still provides similar access and uses the Docker composition defined in the repository.
Switch packages used to test the configuration
cisagovbot
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
cisagovbot
added
the
upstream update
|
I don't think the tests will all pass here until the first-commits PR (#5) is merged. |
There was a problem hiding this comment.
@dav3r I vote we approve and merge this PR because it's only failing when it gets to pushing to the GitHub Container Registry. The failure is to be expected because it's still under the cisagov/example namespace until #5 is merged, and that PR cannot pass tests until the changes in this PR are merged.
Agreed. The old 🐔 and 🥚 conundrum strikes again! |
Lineage Pull Request
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-docker.gitRemote branch:
HEADCheck the changes in this pull request to ensure they won't cause issues with
your project.
✅ Pre-approval checklist
Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml📚 Read more about Lineage