Update CT Search request #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-alexander
added
improvement
|
@king-alexander - The linter failure should go away once the current Kraken flows down to this repository. |
king-alexander
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
jasonodoom
approved these changes
Jun 27, 2023
jsf9k
approved these changes
Jun 28, 2023
The issuance object includes a new field `cert_der` to retrieve the DER-encoded certificate. The previous `cert` field has been deprecated.
The DER-encoded X.509 certificate data is no longer buried in a sub-object, so we decode the result directly.
king-alexander
force-pushed
the
improvement/update-search-requests
branch
from
ed35e88
to
4952803
Compare
king-alexander
added a commit
that referenced
this pull request
Jul 13, 2023
I bungled the version number when I merged #63. This restores Admiral's correct version.
king-alexander
added a commit
that referenced
this pull request
Jul 13, 2023
I bungled the version number when I merged #63. This restores Admiral's correct version.
|
@king-alexander You should mention something in this PR about why version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
I updated the CT Search API request to expand the new
cert_derfield.💭 Motivation and context
According to the SSLMate Changelog, on January 3rd 2023 the
certobject was deprecated. You now usecert_derto retrieve certificate data.🧪 Testing
I verified that our tasks still function as expected with the changes in place. To test, I performed a dry run and monitored progress from the Celery Flower dashboard. The
summary_by_domaintask returned results withcert_derexpanded, and thecert_by_issuancetask returned the base64 representation of the DER-encoded certificate. I stopped the dry run after approximately 10 domains had been scanned.✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist
Note: A
v.1.3.4release will not be built for these changes because the version is semantically incorrect. Thev1.3.3release targets a fix at 3cfcde5.