Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version number #67

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

king-alexander
Copy link
Collaborator

@king-alexander king-alexander commented Jul 13, 2023

πŸ—£ Description

This restores Admiral's correct version number.

πŸ’­ Motivation and context

I bungled the version number when I merged #63 by inadvertently bumping the version twice in 6a8de06. (I failed to sign my commit before timing out the first time.)

πŸ§ͺ Testing

After approvals, I will bump the version again (just once!) to the right number (1.3.3) and make a release.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@king-alexander king-alexander added the bug This issue or pull request addresses broken functionality label Jul 13, 2023
@king-alexander king-alexander self-assigned this Jul 13, 2023
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going through all of this trouble, you may as well just replace 7460478 with a commit that corrects the version to 1.3.3 and call it a day.

I bungled the version number when I merged #63. This restores Admiral's
correct version.
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ You can now check the box for "Finalize version".

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a great commit message!

@king-alexander king-alexander merged commit 3cfcde5 into develop Jul 14, 2023
52 checks passed
@king-alexander king-alexander deleted the bugfix/update-search-requests branch July 14, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants