This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Merge skeleton-python-library #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing to the defusedxml package. Added the #nosec tag to the requests.get() call because we need to use verify=false to successfully connect.
Rename the assessment_data_export() function to export_assessment_data() so I can access the main() function in tests. Correctly tie the version reported by Docopt to match the __version__ set in _versiono.py
|
This pull request introduces 1 alert and fixes 1 when merging f632cb0 into e8c1ace - view on LGTM.com new alerts:
fixed alerts:
|
jsf9k
approved these changes
Feb 27, 2020
src/ade/assessment_data_export.py
Outdated
| @@ -94,7 +96,7 @@ def export_jira_data(jira_base_url, jira_credentials_file, jira_filter, xml_file | |||
| # Export XML data from Jira | |||
| try: | |||
| response = requests.get( | |||
| jira_url, auth=(jira_username, jira_password), verify=False | |||
| jira_url, auth=(jira_username, jira_password), verify=False # nosec | |||
There was a problem hiding this comment.
Why is nosec needed here? It might be good to include a comment.
There was a problem hiding this comment.
Good catch, I mentioned it in the commit but forgot to add a code comment. Hopefully the comment in 2f19cc6 satisfies.
…t checks for a piece of code.
|
This pull request introduces 1 alert and fixes 1 when merging 2f19cc6 into e8c1ace - view on LGTM.com new alerts:
fixed alerts:
|
mcdonnnj
pushed a commit
that referenced
this pull request
Sep 28, 2020
Remove the terraform-docs hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR brings this project into the fold by merging cisagov/skeleton-python-library. This includes migrating the project from Travis CI to GitHub Actions,
💭 Motivation and Context
Since I will need to add some functionality to this project I thought it would be a good idea to bring it in line with other Python projects by merging in
skeleton-python-library.🧪 Testing
All automated tests pass with no issues. I tested the change to
defusedxmlmanually and ensured that a JSON would still be generated correctly from sample XML.🚥 Types of Changes
✅ Checklist