This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Manually Merge skeleton-python-library to Resolve Unrelated Histories Error #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦:cisagov/skeleton-generic into improvement-pytest
β¦es_from_skeleton_generic Pull in upstream changes from skeleton-generic
One for tests and one for everthing else.
Improvement pytest
This should speed up TravisCI builds.
Via pre-commit autoupdate.
Use TravisCI caching to speed up builds
β¦ent/upstream_updates
Upstream updates
This shows how to added data to a package and correctly access it.
Add changes from running pre-commit autoupdate
terraform-docs is currently broken with respect to terraform 0.12.
Remove the terraform-docs hook
β¦ent/merge_in_upstream_changes
β¦nges Merge in upstream changes from cisagov/skeleton-generic
Improvement/data
JSON files are already being linted by the pretty-format-json hook.
β¦re_json_files Configure prettier to ignore JSON files
β¦ent/pull_in_upstream_changes
Pull in upstream changes
Add Snyk badge/shield
Make the job name the first part of the cache key since it is the only part that isn't variable.
β¦nd_cache_actions_to_v2 Update actions/cache and actions/setup-python to v2
All jobs should perform identical work in a consistent manner.
Lineage pull request for: skeleton
Autoupdate pre-commit and Additional Maintenance
Add "requirements.txt" to the actions/cache key for the test job to match what was done for the lint job. Expand the option to pip in requirements.txt to its full, more descriptive form. This matches efforts to do this elsewhere in our codebases.
β οΈ CONFLICT! Lineage pull request for: skeleton
Update action/upload-artifact Version
mcdonnnj
requested review from
dav3r,
felddy,
jsf9k and
a team
as code owners
September 29, 2020 00:46
dav3r
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- thanks @mcdonnnj for catching and fixing this!
No repo left behind! ποΈ π
hillaryj
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! π₯
jsf9k
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π£ Description
This PR is a manual merge of this repository with cisagov/skeleton-python-library, since they appear to have deviated enough that merges no longer automatically succeed (unrelated histories error).
π Motivation and Context
I was checking a recent cisagov/action-lineage run and saw that this repo (among others) was unable to merge. Hopefully manually merging them will allow future automated PRs to generate.
π§ͺ Testing
Just automated tests.
π· Screenshots (if appropriate)
π₯ Types of Changes
β Checklist