Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Manually Merge skeleton-python-library to Resolve Unrelated Histories Error #18

Merged
merged 317 commits into from
Sep 29, 2020

Conversation

mcdonnnj
Copy link
Member

πŸ—£ Description

This PR is a manual merge of this repository with cisagov/skeleton-python-library, since they appear to have deviated enough that merges no longer automatically succeed (unrelated histories error).

πŸ’­ Motivation and Context

I was checking a recent cisagov/action-lineage run and saw that this repo (among others) was unable to merge. Hopefully manually merging them will allow future automated PRs to generate.

πŸ§ͺ Testing

Just automated tests.

πŸ“· Screenshots (if appropriate)

πŸš₯ Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

felddy and others added 30 commits May 6, 2019 12:29
…:cisagov/skeleton-generic into improvement-pytest
…es_from_skeleton_generic

Pull in upstream changes from skeleton-generic
One for tests and one for everthing else.
This should speed up TravisCI builds.
This shows how to added data to a package and correctly access it.
Add changes from running pre-commit autoupdate
terraform-docs is currently broken with respect to terraform 0.12.
…nges

Merge in upstream changes from cisagov/skeleton-generic
JSON files are already being linted by the pretty-format-json hook.
…re_json_files

Configure prettier to ignore JSON files
mcdonnnj and others added 19 commits July 30, 2020 11:08
Make the job name the first part of the cache key since
it is the only part that isn't variable.
…nd_cache_actions_to_v2

Update actions/cache and actions/setup-python to v2
All jobs should perform identical work in a consistent manner.
Lineage pull request for: skeleton
Autoupdate pre-commit and Additional Maintenance
Add "requirements.txt" to the actions/cache key for the test job to match what
was done for the lint job. Expand the option to pip in requirements.txt to its
full, more descriptive form. This matches efforts to do this elsewhere in our
codebases.
⚠️ CONFLICT! Lineage pull request for: skeleton
@mcdonnnj mcdonnnj requested review from dav3r, felddy, jsf9k and a team as code owners September 29, 2020 00:46
@mcdonnnj mcdonnnj self-assigned this Sep 29, 2020
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- thanks @mcdonnnj for catching and fixing this!
No repo left behind! 🏎️ 🏁

Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! πŸ₯‡

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch!

@mcdonnnj mcdonnnj merged commit 75b8902 into develop Sep 29, 2020
@mcdonnnj mcdonnnj deleted the remerge_from_skeleton branch September 29, 2020 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants