Skeletonize the Repository #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing release tag being passed into tests.
…thon Set a default language for pre-commit hooks
…provement/upstream
Improvement/upstream
Add codeowners file with team OIS maintainers.
…provement/codeowners
Improvement/codeowners
Add isort configuration file.
Add isort tool to pre-commit hooks.
…provements/pull_in_upstream_and_run_isort
… not currently support coverage 5.0+ per TheKevJames/coveralls-python#203
…_run_isort Pull in Upstream and Run pre-commit
…g through scripts. Update setup.py to include the semver package which is used by the bump_version.sh script.
…ments-dev.txt file to better match intent.
…sion in the bump_version.sh script.
…tag_scripts Add Scripts for Bumping Versions and Tagging
Add versioning for setuptools to support inclusiong of python_requires argument. Note: This will require pip versions >=9.0.0 for support.
Add python_requires argument for setup.py
A user forked cisagov/scan-target-data and created a pull request, but the required GitHub Action(s) did not run. This is presumably because the user does not have Actions enabled in his or her fork. Ideally, the required Action(s) would run in cisagov/scan-target-data when a PR to merge changes back is created. Based on my reading of this link, adding the "pull_request" event type should make this happen: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
…m-forked-repos Make workflow run when a PR is opened, synchronized, or reopened
…rrect workflow if someone forks and does a pull request.
…hange_from_upstream Pull in build Workflow Changes from Upstream
The v5 release of ansible-lint introduces breaking changes, so we are holding off on updating until things are resolved. Conversation about this can be tracked in cisagov/skeleton-ansible-role#69.
Update pre-commit Hooks
…it_hook Add the beautysh pre-commit hook
Lineage pull request for: skeleton
…rements Add the mypy Package to the Development Package Requirements
Update Package Metadata
…into improvement/skeletonize
Update to mirror the version pin in cisagov/skeleton-ansible-role so we are using the same version that we develop Ansible roles with.
Now that the skeleton is merged in, make sure pre-commit passes.
Add the schema package to align with cisagov/skeleton-python-library and move the sample inventory.txt file into a files/ subdirectory to align with other testing setups.
Add a typical prompt symbol ($) to the README example to better illustrate that it is a command and its output.
mcdonnnj
added
improvement
dav3r
approved these changes
Mar 11, 2021
jsf9k
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR brings the magic of cisagov/skeleton-python-library to this repository!
💭 Motivation and context
I was using this project to test some changes I'm making to resolve cisagov/cyhy_amis#313 and realized when I tried to use the
pre-commithooks to check my YAML inventory file that it was woefully behind. I decided to rectify that since my understanding is that this tool is regularly used.🧪 Testing
Automated tests pass. I was able to use this branch to query my testing environment and retrieve results successfully.
✅ Checklist