Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Molecule builds currently broken #69

Closed
jsf9k opened this issue Feb 15, 2021 · 2 comments · Fixed by #85
Closed

Molecule builds currently broken #69

jsf9k opened this issue Feb 15, 2021 · 2 comments · Fixed by #85
Labels
breaking change This issue or pull request involves changes to existing functionality bug This issue or pull request addresses broken functionality

Comments

@jsf9k
Copy link
Member

jsf9k commented Feb 15, 2021

🐛 Summary

Version 5 of ansible-lint has been released, and it contains some breaking changes that have yet to shake out.

See:

To reproduce

  1. Check out the code for any cisagov Ansible role that is based on cisagov/skeleton-ansible-role or cisagov/skeleton-ansible-role-with-test-user.
  2. Run pip install --upgrade -r requirements-dev.txt.
  3. Run molecule test and watch it fail.

Expected behavior

molecule test should complete successfully for any cisagov Ansible role that is based on cisagov/skeleton-ansible-role or cisagov/skeleton-ansible-role-with-test-user.

Any helpful log output or screenshots

For an example of this bug in an APB build, see here.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality breaking change This issue or pull request involves changes to existing functionality labels Feb 15, 2021
mcdonnnj added a commit that referenced this issue Feb 16, 2021
@mcdonnnj
Pin ansible-lint to <5 to avoid upgrading to the latest version
cca3976 
This update broke our CI configuration as apb dispatched runes failed. This is
documented in #69 and
until things have shaken out a bit more we will hold on the 4.x release(s).
@mcdonnnj mcdonnnj mentioned this issue Feb 16, 2021
Merged
7 tasks
jsf9k added a commit to cisagov/ansible-role-cdm-tanium-client that referenced this issue Feb 16, 2021
@jsf9k
Pin ansible-lint since version 5 contains breaking changes
7cf88a7 
See cisagov/skeleton-ansible-role#69 for more details.
mcdonnnj added a commit to cisagov/skeleton-generic that referenced this issue Feb 16, 2021
@mcdonnnj
Revert ansible-lint version update
c97a883 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
@mcdonnnj mcdonnnj mentioned this issue Feb 16, 2021
Merged
7 tasks
cisagovbot pushed a commit that referenced this issue Feb 16, 2021
@mcdonnnj
Merge pull request #69 from cisagov/maintenance/update_pre-commit_hooks
3313850 
Update pre-commit Hooks
jsf9k added a commit to cisagov/ansible-role-cdm-nessus-agent that referenced this issue Feb 17, 2021
@jsf9k
Pin ansible-lint since version 5 contains breaking changes
3c9a74d 
See cisagov/skeleton-ansible-role#69 for more details.
jsf9k added a commit to cisagov/ansible-role-cdm-nessus-agent that referenced this issue Feb 17, 2021
@jsf9k
Pin ansible-lint since version 5 contains breaking changes
8869fa8 
See cisagov/skeleton-ansible-role#69 for more details.
This was referenced Feb 22, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 1, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jsf9k pushed a commit to cisagov/ansible-role-cdm-tanium-client that referenced this issue Mar 8, 2021
@mcdonnnj @jsf9k
Revert ansible-lint version update
d34838f 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
jsf9k pushed a commit to cisagov/ansible-role-cdm-tanium-client that referenced this issue Mar 8, 2021
@mcdonnnj @jsf9k
Pin ansible-lint to <5 to avoid upgrading to the latest version
500df26 
This update broke our CI configuration as apb dispatched runes failed. This is
documented in cisagov/skeleton-ansible-role#69 and
until things have shaken out a bit more we will hold on the 4.x release(s).
jsf9k pushed a commit to cisagov/cool-sharedservices-cdm that referenced this issue Mar 8, 2021
@mcdonnnj @jsf9k
Revert ansible-lint version update
871f981 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
jsf9k pushed a commit to cisagov/cool-sharedservices-cdm that referenced this issue Mar 8, 2021
@mcdonnnj @jsf9k
Revert ansible-lint version update
4725468 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
jsf9k pushed a commit to cisagov/cool-sharedservices-cdm that referenced this issue Mar 8, 2021
@mcdonnnj @jsf9k
Revert ansible-lint version update
10d3f32 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
@dav3r dav3r mentioned this issue Jul 1, 2021
Closed
@dav3r
Copy link
Member

dav3r commented Oct 20, 2021

@cisagov/team-ois - Is this issue still valid or can it now be closed out?

@jsf9k
Copy link
Member Author

jsf9k commented Oct 20, 2021 •
edited
Loading

@cisagov/team-ois - Is this issue still valid or can it now be closed out?

I have mentioned this issue in the relevant PR.

@jsf9k jsf9k mentioned this issue Oct 20, 2021
Merged
6 tasks
@mcdonnnj mcdonnnj moved this to Done in Skeleton Maintenance Feb 2, 2023
Sallenmoore pushed a commit to Sallenmoore/foundryvtt-docker that referenced this issue Jun 18, 2023
@mcdonnnj
Revert ansible-lint version update
4cfd566 
The v5 release of ansible-lint introduces breaking changes, so we are holding
off on updating until things are resolved. Conversation about this can be
tracked in cisagov/skeleton-ansible-role#69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This issue or pull request involves changes to existing functionality bug This issue or pull request addresses broken functionality
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin ansible-lint cisagov/skeleton-ansible-role
2 participants
@jsf9k @dav3r