Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible requirement from <5,>=2.10 to >=2.10,<6 #12

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 6, 2021

Updates the requirements on ansible to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [ansible](https://github.com/ansible/ansible) to permit the latest version.
- [Release notes](https://github.com/ansible/ansible/releases)
- [Commits](https://github.com/ansible/ansible/commits)

---
updated-dependencies:
- dependency-name: ansible
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Dec 6, 2021
@jsf9k jsf9k self-assigned this Dec 6, 2021
@dav3r
Copy link
Member

dav3r commented Dec 6, 2021

Don't we just want to wait for this change to flow in through the Lineage update process?

@jsf9k
Copy link
Member

jsf9k commented Dec 6, 2021

Don't we just want to wait for this change to flow in through the Lineage update process?

The upstream for this repo is cisagov/skeleton-python-library, which doesn't have Ansible as a dependency.

@dav3r
Copy link
Member

dav3r commented Dec 6, 2021

Don't we just want to wait for this change to flow in through the Lineage update process?

The upstream for this repo is cisagov/skeleton-python-library, which doesn't have Ansible as a dependency.

Ah, I always forget about that! 👍

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj
Copy link
Member

@jsf9k Do we want to go ahead and merge this now that this change trickled to the Ansible role repositories?

@mcdonnnj
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 27, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jsf9k
Copy link
Member

jsf9k commented Jan 27, 2022

@jsf9k Do we want to go ahead and merge this now that this change trickled to the Ansible role repositories?

Yes, please do that.

@mcdonnnj
Copy link
Member

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 31, 2022

A newer version of ansible exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@mcdonnnj
Copy link
Member

@dependabot recreate

@mcdonnnj mcdonnnj force-pushed the dependabot/pip/ansible-gte-2.10-and-lt-6 branch from 16a343a to 60d8fec Compare February 25, 2022 23:09
@mcdonnnj
Copy link
Member

@dependabot rebase

@mcdonnnj mcdonnnj force-pushed the dependabot/pip/ansible-gte-2.10-and-lt-6 branch from 60d8fec to c0b4ab9 Compare February 25, 2022 23:45
@mcdonnnj
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 11, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mcdonnnj
Copy link
Member

@dependabot recreate

@mcdonnnj mcdonnnj merged commit eed52eb into develop Mar 11, 2022
@mcdonnnj mcdonnnj deleted the dependabot/pip/ansible-gte-2.10-and-lt-6 branch March 11, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants