Add fix for Debian Bookworm/cloud-init/Netplan/DHCP issue #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
bug
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
jsf9k
added
the
blocked
michaelsaki
approved these changes
Feb 20, 2024
The Netplan config is created by cloud-init, but it needs to be slightly modified and reapplied. This script takes care of the modification. See these issues for more details: - cisagov/skeleton-packer#300 - canonical/cloud-init#4764
The Netplan config is created by cloud-init, but it needs to be slightly modified and reapplied. There is a Python script that fixes the DHCP4 options in the netplan configuration already generated by cloud-init. This cloud-init fragment simply reapplies the Netplan configuration after the modification. See these issues for more details: - cisagov/skeleton-packer#300 - canonical/cloud-init#4764
The Netplan config is created by cloud-init, but it needs to be slightly modified and reapplied. See these issues for more details: - cisagov/skeleton-packer#300 - canonical/cloud-init#4764
See #234 for more details.
jsf9k
force-pushed
the
testing/netplan-dhcp-fix
branch
from
ac1e0f7
to
5280cef
Compare
8 tasks
jsf9k
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a fix for the Debian Bookworm +
cloud-init+netplan+ DHCP issue described in cisagov/skeleton-packer#300.Important
This pull request cannot be merged until cisagov/skeleton-packer#242 is merged and trickles down to all the COOL AMI repos.
💭 Motivation and context
See cisagov/skeleton-packer#300.
🧪 Testing
I deployed these changes together with those from this branch of cisagov/debian-packer and verified that
debiandesktop0couldpingterraformer0without having to specify the.env6domain.✅ Pre-approval checklist