Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cisagov fork of 18F/domain-scan #96

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Use cisagov fork of 18F/domain-scan #96

merged 3 commits into from
Feb 1, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 31, 2023 •
edited
Loading

🗣 Description

This pull request modifies the code to use the cisagov fork of 18F/domain-scan.

💭 Motivation and context

The cisagov fork is being kept up to date, and the original 18F repo is archived.

🧪 Testing

All automated tests pass. I also ran the gathering portion of the BOD 18-01 scanning with these changes and verified that it functions as before.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number labels Jan 31, 2023
@jsf9k jsf9k added this to In progress in BOD 18-01 via automation Jan 31, 2023
@jsf9k jsf9k self-assigned this Jan 31, 2023
@jsf9k jsf9k marked this pull request as ready for review February 1, 2023 15:23
@jsf9k jsf9k requested a review from a team February 1, 2023 15:23
jsf9k added a commit to cisagov/orchestrator that referenced this pull request Feb 1, 2023
@jsf9k
Use the latest gatherer and scanner Docker images
aaee297 
See cisagov/gatherer#96 and cisagov/scanner#74 for more details.
@jsf9k jsf9k mentioned this pull request Feb 1, 2023
Merged
7 tasks
mcdonnnj
mcdonnnj reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but please update the README to reference our fork of 18F/domain-scan. The blurb in cisagov/lambda_functions would be good for completeness.

@jsf9k @mcdonnnj
Reference the cisagov fork of 18F/domain-scan
4bb34ff 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jsf9k
Copy link
Member Author

jsf9k commented Feb 1, 2023

This looks good but please update the README to reference our fork of 18F/domain-scan. The blurb in cisagov/lambda_functions would be good for completeness.

Please see commit 4bb34ff.

@jsf9k jsf9k requested a review from mcdonnnj February 1, 2023 16:00
mcdonnnj
mcdonnnj approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

BOD 18-01 automation moved this from In progress to Reviewer approved Feb 1, 2023
@jsf9k jsf9k merged commit e6993ac into develop Feb 1, 2023
BOD 18-01 automation moved this from Reviewer approved to Done Feb 1, 2023
@jsf9k jsf9k deleted the improvement/use-cisagov-fork-of-domain-scan branch February 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number
Projects
BOD 18-01
Status: Done
BOD 18-01
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsf9k @dav3r @mcdonnnj