Use the latest gatherer and scanner Docker images #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
dav3r
approved these changes
Feb 1, 2023
mcdonnnj
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the Docker composition to use the latest Docker images from cisagov/gatherer and cisagov/scanner.
💭 Motivation and context
The new Docker images use the cisagov fork of 18F/domain-scan. This is necessary since 18F/domain-scan has been archived, while the cisagov fork is being kept up to date.
Please see cisagov/gatherer#96 and cisagov/scanner#74 for more details.
🧪 Testing
I performed a full scanning run with these new Docker images and verified that they behaved as expected.
✅ Pre-approval checklist
✅ Post-merge checklist