Remove pyfakefs Workaround for Missing /dev/null #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apb requested GH Actions run for this repo failed on 2020-12-25. Upon investigation I saw that the error was FileExistsError: [Errno 17] File exists in the fake filesystem: '/dev/null' I then checked for recent releases for pyfakefs (and pytest), and saw that v4.3.3 came out on 2020-12-20. Looking into changes I saw that pyfakefs fixed the null device name in pytest-dev/pyfakefs@f1e5163 , which appears to have been the underlying problem that caused us to manually create '/dev/null' in the first place to workaround pytest needing it for the caplog fixture.
dav3r
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR removes the manual creation of
/dev/nullthat was added in #15 to resolve issues with pytest v6.💭 Motivation and Context
I saw that on 2020-12-25 the apb requested GitHub Actions run failed. Upon investigation I saw that pyfakefs v4.3.3 was released on 2020-12-20. Digging into the changes I saw that in pytest-dev/pyfakefs@f1e5163 they fixed the null device name (
/dev/nul -> /dev/null), which is likely why we had to manually create it previously.🧪 Testing
Tests pass as expected again.
✅ Checklist