-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Redis to a nonstandard port #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to avoid conflict with the Admiral, which also uses Redis.
This port is only ever used for debugging from the Docker host, so there is no need to listen on all network interfaces.
jsf9k
added
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
version bump
This issue or pull request increments the version number
labels
Apr 24, 2023
dav3r
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with one suggestion that you may take or leave.
So future readers know what we are talking about. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
mcdonnnj
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable enough.
dv4harr10
approved these changes
Apr 25, 2023
cisagovbot
pushed a commit
that referenced
this pull request
Sep 13, 2023
Use the correct repo name for the ansible-lint pre-commit hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
version bump
This issue or pull request increments the version number
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request:
6379
(if theports
section of theredis
service is uncommented).ports
section by key.host_ip
key to theports
dictionary to restrict Redis access to only the Docker host.💭 Motivation and context
ports
dictionary is uncommented, the exposed port is only used for debugging purposes from the Docker host; therefore, it only makes sense to listen for local traffic.🧪 Testing
All automated tests pass. I also started up the
redis
service with theports
dictionary uncommented and verified thatredis-cli
functions as expected from the Docker host.✅ Pre-approval checklist
✅ Post-merge checklist