This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
1 - Implement Shodan and Credential views into report generator #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify the metrics required to generate the reports we have created new db views, this commit implements those changes across the report generator
|
This pull request introduces 4 alerts when merging 09ac0e3 into c926100 - view on LGTM.com new alerts:
|
add server to the db_schema
|
This pull request introduces 4 alerts when merging f78b708 into c926100 - view on LGTM.com new alerts:
|
aloftus23
changed the title
aloftus23
changed the title
9 tasks
aloftus23
changed the title
aloftus23
changed the title
|
This pull request introduces 1 alert when merging 040b1de into 78ccbfd - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 65ea84f into 78ccbfd - view on LGTM.com new alerts:
|
Can't import same name
|
@DJensen94 @cduhn17 I got this one working finally. Is it worth reviewing and setting up to be merged next? Or should we shift to another? |
DJensen94
commented
Oct 27, 2022
DJensen94
commented
Oct 27, 2022
Update the get_orgs function to create a connection if one is not provided
get_orgs always requires a connection so we should revert this change
DJensen94
requested review from
cduhn17,
dav3r,
felddy,
jsf9k,
mcdonnnj and
stewartl97
as code owners
|
@dav3r This PR is ready for review |
cduhn17
approved these changes
Oct 31, 2022
dav3r
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172, fixes #176, fixes #181
To simplify the metrics required to generate the reports we have created new db views, this PR implements those changes across the report generator
💭 Motivation and context
A lot of the data manipulation in the metrics file is difficult to read and can be implemented into views inside our db. By querying directly from these views we speed up our report generation and simplify our code.
✅ Pre-approval checklist