This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
Add report generator page to UI #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add report generator page to UI to generate biweekly reports and bulletins for cybersix alerts and credential breaches
add helpers folder to package data to be able to reference helpers from app
Moved bulletin folder to the correct helpers folder
|
This pull request introduces 1 alert when merging 0ee5ef4 into 78ccbfd - view on LGTM.com new alerts:
|
add pdfkit to the modules in setup file
|
This pull request introduces 1 alert when merging ed5d8cc into 78ccbfd - view on LGTM.com new alerts:
|
Update the logging declaration in the config file in pe-source folder
|
This pull request introduces 1 alert when merging fe2dd83 into 78ccbfd - view on LGTM.com new alerts:
|
Renamed filename and references to avoid issue with duplicated names
update the call to add central logging
Update the form label instructions to clarify what day should be used to generate the report.
|
This pull request introduces 1 alert when merging 1cb092c into 78ccbfd - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 7d57e76 into 78ccbfd - view on LGTM.com new alerts:
|
Move date and filename validation into their own functions
…thub.com/cisagov/pe-reports into DJ-add_report_and_bulletin_generator-WIP
|
This pull request introduces 1 alert when merging 1596da2 into 78ccbfd - view on LGTM.com new alerts:
|
aloftus23
reviewed
Oct 21, 2022
src/pe_reports/report_gen/templates/report_gen_UI/home_report_gen.html
Outdated
Show resolved
Hide resolved
Fix text for cybersixgill to be one word instead of two Co-authored-by: aloftus23 <79927030+aloftus23@users.noreply.github.com>
|
This pull request introduces 1 alert when merging ea8a1b1 into 78ccbfd - view on LGTM.com new alerts:
|
change print statements to logging statements
aloftus23
approved these changes
Oct 21, 2022
Fix the root domain query functions docstring to be clear. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Update log statement to not use f-strings and clarify meaning Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove unused today's date variable Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove camel case to keep consistency Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove camel case to keep consistency Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove camel case to keep consistency Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Simplify the method for checking if a provided date is the last day of the month Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Test if a leap year occurs on the user provided date Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove f-string from log message Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
remove unnecessary spaces from url_for call Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Implement snake case into the naming of all the form variables
Fix spelling issue and remove confusing part of error message. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Target flake8 exception to specific instance that needs to be overruled instead of opening up the whole repo
When a date does not meet the standards return False
Fix the spelling of an updated variable
Explain why we are using a different logger call in this file, which is to avoid circular references
Explaining why we are adding numbers after the variable names to distinguish between them
dav3r
reviewed
Oct 25, 2022
dav3r
reviewed
Oct 25, 2022
src/pe_reports/report_gen/templates/report_gen_UI/home_report_gen.html
Outdated
Show resolved
Hide resolved
Explain why we are calling the logger differently in the config file
Capitalize HTML in html_builder function's docstring Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Remove space after variable in the html file to keep consistency. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Fix the typo in the comment explaining the logger connection
…thub.com/cisagov/pe-reports into DJ-add_report_and_bulletin_generator-WIP
dav3r
approved these changes
Oct 25, 2022
cduhn17
approved these changes
Oct 25, 2022
aloftus23
added
the
duplicate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add report generator page to UI. This page will be used to generate biweekly reports and bulletins for cybersixgill alerts and credential breaches when we identify a critical issue that needs to be sent to stakeholders immediately.
Fixes #241
💭 Motivation and context
In the past reports were generated through a command line program that isn't super user friendly. This is designed to ensure that any P&E team member can generate the reports without any technical knowledge of the process.
✅ Pre-approval checklist
to reflect the changes in this PR.