Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Pull in Upstream Changes #3

Merged
merged 22 commits into from
May 1, 2020
Merged

Pull in Upstream Changes #3

merged 22 commits into from
May 1, 2020

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented May 1, 2020

πŸ—£ Description

Updates! We have them! This repo needs them!

πŸ’­ Motivation and Context

Keeping things up-to-date.

πŸ§ͺ Testing

Local and GitHub Actions tests pass.

πŸ“· Screenshots (if appropriate)

πŸš₯ Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

mcdonnnj and others added 22 commits March 4, 2020 08:41
…cks to environment variables declared before the job block.
Change Cache Paths to Environment Variables
…ame as long

as they are not nested in the same heading group.
Add markdownlint Configuration Option for MD024
  terraform_validate_no_variables was changed to terraform_validate in the
  following commit:
  antonbabenko/pre-commit-terraform@35e0356.
Ran pre-commit autoupdate.
Update pre-commit Hooks and Fix Broken Hook ID
`pre-commit-terraform` hook since the PR I submitted,
antonbabenko/pre-commit-terraform#100,
was approved. This will fix issues with `skeleton-tf-module` related to multiple
directories with Terraform code.
…hen the

failure is with setup rather than hooks running.
…lding.

Adjust description for pre-commit hook setup to better convey what is being
done.
…commit-terraform_hook

Update pre-commit Hooks to Include Bugfix
Pull in upstream changes from cisagov/skeleton-generic
@mcdonnnj mcdonnnj requested review from dav3r, felddy, jsf9k and a team as code owners May 1, 2020 16:37
@mcdonnnj mcdonnnj self-assigned this May 1, 2020
@mcdonnnj mcdonnnj added this to In progress in Skeleton Maintenance via automation May 1, 2020
@mcdonnnj mcdonnnj requested a review from hillaryj May 1, 2020 16:37
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛷️

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Skeleton Maintenance automation moved this from In progress to Reviewer approved May 1, 2020
@mcdonnnj mcdonnnj merged commit cf24607 into develop May 1, 2020
Skeleton Maintenance automation moved this from Reviewer approved to Done May 1, 2020
@mcdonnnj mcdonnnj deleted the improvement/upstream-changes branch May 1, 2020 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants