Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Sep 13, 2022

🗣 Description

This pull request tightens a few sed commands so that their regexes do not inadvertently match when they should not.

💭 Motivation and context

We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.

🧪 Testing

I tested locally and verified that with these changes the situation that arose in cisagov/postfix-docker#47 does not occur.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

We saw in cisagov/postfix-docker#47 that the sed commands in the
bump_version.sh script could inadvertently match the CC0 version in
the README.md file.  This change escapes the periods in the version
before passing it on to sed so that they only match periods and not
just any character.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality blocked This issue or pull request is awaiting the outcome of another issue or pull request labels Sep 13, 2022
@jsf9k jsf9k assigned jsf9k and mcdonnnj and unassigned mcdonnnj Sep 13, 2022
@jsf9k
Copy link
Member Author

jsf9k commented Sep 13, 2022

This repo needs a lineage PR before the linting tasks can pass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocked This issue or pull request is awaiting the outcome of another issue or pull request bug This issue or pull request addresses broken functionality

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants