-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for generate_reports() #53
Conversation
Pull Request Test Coverage Report for Build 6509751953
💛 - Coveralls |
…2/test_generate_reports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few small wording changes here.
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
…ata(). Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! 👍
Note that if your pre-merge and post-merge checklists are empty, then those sections can be deleted. However, now that @nickviola is starting to version this repo, you should ensure that this PR updates the version appropriately.
🗣 Description
This PR adds test cases for generate_reports() in tpt_reports.py. Resolves Issue #22
💭 Motivation and context
The added test cases will test ensure that negative boolean status values will be returned if load_json_file() returns a null JSON object, or if parse_json() was not able to parse out valid fields from the file and returns null objects.
🧪 Testing
Testing was performed by running PyTest and ensured all added and pre-existing test cases were passing.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist