Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for generate_reports() #53

Merged
merged 18 commits into from
Oct 13, 2023

Conversation

JCantu248
Copy link
Contributor

@JCantu248 JCantu248 commented Sep 26, 2023

🗣 Description

This PR adds test cases for generate_reports() in tpt_reports.py. Resolves Issue #22

💭 Motivation and context

The added test cases will test ensure that negative boolean status values will be returned if load_json_file() returns a null JSON object, or if parse_json() was not able to parse out valid fields from the file and returns null objects.

🧪 Testing

Testing was performed by running PyTest and ensured all added and pre-existing test cases were passing.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

✅ Post-merge checklist

@JCantu248 JCantu248 added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Sep 26, 2023
@JCantu248 JCantu248 self-assigned this Sep 26, 2023
@coveralls
Copy link

coveralls commented Sep 27, 2023

Pull Request Test Coverage Report for Build 6509751953

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 6487626291: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@JCantu248 JCantu248 requested review from jsf9k and dav3r October 4, 2023 19:33
@JCantu248 JCantu248 marked this pull request as ready for review October 4, 2023 19:33
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a few small wording changes here.

tests/test_tpt_reports.py Outdated Show resolved Hide resolved
tests/test_tpt_reports.py Outdated Show resolved Hide resolved
tests/test_tpt_reports.py Outdated Show resolved Hide resolved
tests/test_tpt_reports.py Outdated Show resolved Hide resolved
JCantu248 and others added 4 commits October 13, 2023 09:43
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
…ata().

Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! 👍

Note that if your pre-merge and post-merge checklists are empty, then those sections can be deleted. However, now that @nickviola is starting to version this repo, you should ensure that this PR updates the version appropriately.

@JCantu248 JCantu248 merged commit 47434db into develop Oct 13, 2023
43 checks passed
@JCantu248 JCantu248 deleted the issue-22/test_generate_reports branch October 13, 2023 15:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants