Pull in Upstream Updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user forked cisagov/scan-target-data and created a pull request, but the required GitHub Action(s) did not run. This is presumably because the user does not have Actions enabled in his or her fork. Ideally, the required Action(s) would run in cisagov/scan-target-data when a PR to merge changes back is created. Based on my reading of this link, adding the "pull_request" event type should make this happen: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#pull-request-events-for-forked-repositories
…m-forked-repos Make workflow run when a PR is opened, synchronized, or reopened
Cleanup Linux instructions and add WSL references to CONTRIBUTING.md
Update actions/checkout to v2 Update formatting to match downstream children
…n_and_checkout_action Update Python and actions/checkout Versions
Update pre-commit hooks (and flip Actions cache order in workflow).
…provements/pull_in_upstream_updates
…--verbose --all-files).
… is breaking coveralls uploads.
Add comment explaining why coveralls is being pinned.
… is released which fixed the regression introduced in 1.11.0 per https://github.com/coveralls-clients/coveralls-python/releases/tag/1.11.1
… verbose '--requirement'.
…ches Use Verbose pip Switches
…provements/pull_in_upstream_updates
…ates Pull in Updates from skeleton-generic
Add static type checking to the Python skeleton
Autoupdate pre-commit hooks. Add mypy.
The v5 release of ansible-lint introduces breaking changes, so we are holding off on updating until things are resolved. Conversation about this can be tracked in cisagov/skeleton-ansible-role#69.
Update pre-commit Hooks
…it_hook Add the beautysh pre-commit hook
Lineage pull request for: skeleton
…rements Add the mypy Package to the Development Package Requirements
Update Package Metadata
I noticed the following warning when looking at GHA workflow runs: 1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results. After looking into it I updated the workflow per this page on GitHub Docs: https://docs.github.com/en/github/finding-security-vulnerabilities-and-errors-in-your-code/troubleshooting-the-codeql-workflow#warning-git-checkout-head2-is-no-longer-necessary
Update CodeQL Workflow for GitHub Actions
mcdonnnj
added
improvement
|
Working on a review now, but I noticed that vpn-config-gen/bump_version.sh Line 9 in 9098697 src/vpnconf/_version.py
|
dav3r
approved these changes
Apr 6, 2021
Also fix the block quote in the README to use a format and correctly render the first line of output.
mcdonnnj
force-pushed
the
improvement/upstream_updates
branch
from
9098697
to
99d1a37
Compare
jsf9k
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR pulls in the latest from cisagov/skeleton-python-library, which will also get this repository on the cisagov/action-lineage train. There is also a typo fix and formatting adjustment to the README.
💭 Motivation and context
I went to use this utility to check my VPN configuration and was surprised to see that I was still up-to-date locally even though it has been some time since I last used this project. Out of curiosity I checked and noticed that this repository was missing the
lineage-fu that would keep it up-to-date with the appropriate skeleton repository.🧪 Testing
Automated tests pass.
✅ Checklist