Bfd for bgp_neighbor (#419)

* errors fixed

* interval array change

* missing ipv6 default

* remove name

* add exclude for interval

* Add comments

* Review comment fixes

* bfd prop added to bgp_neighbor

* CHANGELOG

* review comment

* rview comments

CHANGELOG.md

@@ -9,6 +9,11 @@ Changelog
 * Bidirectional Forwarding Detection
   * bfd (@saichint)
 
+### Added
+
+* Extend cisco_bgp_neighbor with attributes:
+   * `bfd`
+
 ## [v1.3.1]
 
 ### Changed

lib/cisco_node_utils/bgp_neighbor.rb

@@ -88,6 +88,20 @@ def set_args_keys(hash={}) # rubocop:disable Style/AccessorMethodName
       @set_args = @set_args.merge!(hash) unless hash.empty?
     end
 
+    def bfd=(val)
+      set_args_keys(state: (val) ? '' : 'no')
+      Feature.bfd_enable
+      config_set('bgp_neighbor', 'bfd', @set_args)
+    end
+
+    def bfd
+      config_get('bgp_neighbor', 'bfd', @get_args)
+    end
+
+    def default_bfd
+      config_get_default('bgp_neighbor', 'bfd')
+    end
+
     def description=(desc)
       fail TypeError unless desc.is_a?(String)
       desc.strip!

lib/cisco_node_utils/cmd_ref/bgp_neighbor.yaml

@@ -20,6 +20,13 @@ all_neighbors:
     - "(?)vrf <vrf>"
   get_value: '/^neighbor (\S+)$/'
 
+bfd:
+  _exclude: [ios_xr]
+  kind: boolean
+  get_value: '/^bfd$/'
+  set_value: '<state> bfd'
+  default_value: false
+
 capability_negotiation:
   _exclude: [ios_xr]
   auto_default: false

tests/test_bgp_neighbor.rb

@@ -265,6 +265,26 @@ def test_dynamic_capability
     end
   end
 
+  def test_bfd
+    %w(default test_vrf).each do |vrf|
+      neighbor = create_neighbor(vrf)
+      if validate_property_excluded?('bgp_neighbor', 'bfd')
+        assert_nil(neighbor.bfd)
+        assert_nil(neighbor.default_bfd)
+        assert_raises(Cisco::UnsupportedError) do
+          neighbor.bfd = true
+        end
+      else
+        check = [false, true, neighbor.default_bfd]
+        check.each do |value|
+          neighbor.bfd = value
+          assert_equal(value, neighbor.bfd)
+        end
+      end
+      neighbor.destroy
+    end
+  end
+
   def test_ebgp_multihop
     %w(default test_vrf).each do |vrf|
       neighbor = create_neighbor(vrf)