-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ospf_area_virtual_link #436
Merged
Merged
Changes from 39 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4e4a708
partial code commit, no test yet
1f2166c
partial testing
c4c3025
range added
7a72fdb
fix range
f5955ad
fix default cost
497265b
Added comments
7e03f91
other method add
1f19249
review comments
f65107f
partial review comments fixed
dcefefc
partial review comments fixed
be81ce3
fix auth and stub
e81b560
All review comments fixed
5aaf16c
Merge remote-tracking branch 'upstream/develop' into ospf
decb039
bug ID added
9c05e3f
Merge remote-tracking branch 'upstream/develop' into ospf
b51efb4
Merge remote-tracking branch 'upstream/develop' into ospf
4d96204
nssa translate added
0643c85
nssa properties added
5aef499
Merge remote-tracking branch 'upstream/develop' into ospf
7b491af
comments added
d168fe6
route-map default is empty
64dcadf
skip few tests for n8k due to bugs
7c51168
Review comments
e835d54
Merge remote-tracking branch 'upstream/develop' into ospf
1af555d
Merge remote-tracking branch 'upstream/develop' into ospf
4d09429
first commit
a28f2eb
test code for vls
0066bc1
test code for vls
1f4d91a
add more tests
b531699
auth added
84f0494
cleartext added
91f7d6d
Merge remote-tracking branch 'upstream/develop' into ospf
c0c3bea
authentication_key_pw added
dbe3e4e
message_digest_key added
dd4412e
Merge remote-tracking branch 'upstream/develop' into ospf
ce72f93
default for key_id
2eeb206
comments add
1971aa8
CHANGELOG fixed
e48eab7
comment added
62da95d
review coments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ Changelog | |
* bfd (@saichint) | ||
* OSPF | ||
* ospf_area (@saichint) | ||
* ospf_area_vl (@saichint) | ||
|
||
### Added | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
# ospf_area_vl | ||
--- | ||
_exclude: [ios_xr] | ||
|
||
_template: | ||
get_command: "show running ospf | no-more" | ||
context: | ||
- "router ospf <name>" | ||
- "(?)vrf <vrf>" | ||
- "area <area> virtual-link <vl>" | ||
|
||
auth_key_chain: | ||
get_value: '/^authentication key-chain (\S+)$/' | ||
set_value: '<state> authentication key-chain <key_id>' | ||
default_value: false | ||
|
||
authentication: | ||
# the config can be 'authentication' or 'authentication message-digest' | ||
# or 'authentication null' or | ||
# no authentication config at all so need to grab the | ||
# optional match to get the whole config for checking | ||
# the mode | ||
get_value: '/^authentication(?:\s+\S+)?$/' | ||
set_value: '<state> authentication <auth>' | ||
default_value: false | ||
|
||
authentication_key_enc_type: | ||
get_value: '/^authentication-key (\d+)/' | ||
default_value: '0' | ||
|
||
authentication_key_password: | ||
get_value: '/^authentication-key \d+ (\S+)/' | ||
default_value: '' | ||
|
||
authentication_key_set: | ||
set_value: "<state> authentication-key <enctype> <password>" | ||
|
||
dead_interval: | ||
kind: int | ||
get_value: '/^dead-interval (\d+)$/' | ||
set_value: 'dead-interval <interval>' | ||
default_value: 40 | ||
|
||
hello_interval: | ||
kind: int | ||
get_value: '/^hello-interval (\d+)$/' | ||
set_value: 'hello-interval <interval>' | ||
default_value: 10 | ||
|
||
message_digest_key_alg_type: | ||
get_value: '/^message-digest-key \d+ (\S+)/' | ||
default_value: 'md5' | ||
|
||
message_digest_key_enc_type: | ||
get_value: '/^message-digest-key \d+ \S+ (\d+)/' | ||
default_value: '0' | ||
|
||
message_digest_key_id: | ||
kind: int | ||
get_value: '/^message-digest-key (\d+)/' | ||
default_value: 0 | ||
|
||
message_digest_key_password: | ||
get_value: '/^message-digest-key \d+ \S+ \d+ (\S+)/' | ||
default_value: '' | ||
|
||
message_digest_key_set: | ||
set_value: "<state> message-digest-key <keyid> <algtype> <enctype> <password>" | ||
|
||
retransmit_interval: | ||
kind: int | ||
get_value: '/^retransmit-interval (\d+)$/' | ||
set_value: 'retransmit-interval <interval>' | ||
default_value: 5 | ||
|
||
transmit_delay: | ||
kind: int | ||
get_value: '/^transmit-delay (\d+)$/' | ||
set_value: 'transmit-delay <delay>' | ||
default_value: 1 | ||
|
||
virtual_links: | ||
multiple: true | ||
context: | ||
- "router ospf <name>" | ||
- "(?)vrf <vrf>" | ||
get_value: '/^area (\S+) virtual-link (\S+)$/' | ||
set_value: '<state> area <area> virtual-link <vl>' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the name is getting long. I'd prefer more than just an abbreviation though for customer-facing names. How does
ospf_area_vlink
sound? That's somewhat in line with our private-vlan /pvlan
naming.