Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI hint directive #59

Merged
merged 7 commits into from
Mar 15, 2022
Merged

Update UI hint directive #59

merged 7 commits into from
Mar 15, 2022

Conversation

cmata23x3
Copy link
Member

Updating the SDK to have consistent hint directive usage as Assistant NLP

For UIHint

  • removing unused display_immediately param
  • making prompt optional and only including in payload when provided

For AsrHint and UIHint

  • updating the text key to be consistent with ANLP usage

Copy link
Contributor

@snow0x2d0 snow0x2d0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You'll need to update the mindmeld dependency to a later version so that tests can run. There's an unpinned dependency that's only fixed in > 4.4.2

@snow0x2d0
Copy link
Contributor

Whoops, looks like this is actually a problem with our actions script. Go ahead and merge this and I'll fix it in another branch.

@cmata23x3 cmata23x3 merged commit 12ebca0 into main Mar 15, 2022
@cmata23x3 cmata23x3 deleted the update-ui-hint-directive branch March 15, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants