Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort keys in the jsonschema alphabetically #148

Closed
jspaaks opened this issue May 15, 2021 · 7 comments
Closed

sort keys in the jsonschema alphabetically #148

jspaaks opened this issue May 15, 2021 · 7 comments
Assignees
@sdruskat
Milestone
1.2.0

Comments

@jspaaks
Copy link
Member

jspaaks commented May 15, 2021

makes them easier to find, especially in longer lists
@sdruskat sdruskat added this to the 1.2.0 milestone May 18, 2021
@sdruskat
Copy link
Member

Suggest to do that in a separate PR once we're happy with the schema as such.

@jspaaks
Copy link
Member Author

jspaaks commented May 18, 2021

Agree. Or alternatively, if we find ourselves in a position where there arent any open PRs

@jspaaks
Copy link
Member Author

jspaaks commented May 20, 2021 •
edited
Loading

When we're ready,

cat schema.json | jq -S --indent 4 '.' > schema.json.new

This was referenced May 28, 2021
Merged
Merged
@sdruskat
Copy link
Member

@jspaaks As currently there are no open PRs that change schema.json, I'll fix this now.

sdruskat added a commit that referenced this issue Jun 21, 2021
@sdruskat
Sort fields in schema.json alphabetically
24a6b14 
- Fix #148
- Use cat schema.json | jq -S --indent 4 '.' > schema.json.new +
mv schema.json.new schema.json to overwrite schema.json with
alphabeticall sorted fields
@sdruskat sdruskat mentioned this issue Jun 21, 2021
Merged
@sdruskat
Copy link
Member

Done in #218.

@jspaaks
Copy link
Member Author

jspaaks commented Jun 22, 2021

Took the liberty to assign you since the work was already done

@sdruskat
Copy link
Member

Added and merged, closing.
For future changes to schema.json, it is the maintainers (our) responsibility to make sure the linting runs smoothly before merging PRs I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdruskat sdruskat

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@sdruskat @jspaaks