Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint schema #201

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Lint schema #201

merged 5 commits into from
Jun 22, 2021

Conversation

jspaaks
Copy link
Member

@jspaaks jspaaks commented Jun 2, 2021

BTW I branched off the wrong branch, so need to wait for merge of PR #196 first

Related issues

Refs: #none

Describe the changes made in this pull request

This PR adds a simple linter for the schema file, to see that the keys are sorted and indented right

Instructions to review the pull request

look at the github action results for linting / lint schema (will fail until we fix #148 / PR #218)

@jspaaks jspaaks marked this pull request as ready for review June 22, 2021 08:31
Copy link
Member

@sdruskat sdruskat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@sdruskat
Copy link
Member

Merging with expected linting failures (should pass once #218 is merged).

@sdruskat sdruskat merged commit 38d9b1f into 1.2.0 Jun 22, 2021
@sdruskat sdruskat deleted the lint-schema branch June 22, 2021 09:40
@sdruskat
Copy link
Member

Yay, now onward to merging #218. Can you do the honour, @jspaaks?

@jspaaks jspaaks mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants