-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple affiliations #523
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two ways to go with this pull request:
- Accept the risk of misuse and safety issues (
date-start
being taken for the lifetime of the entity itself, not the affiliation; potentially infinite recursion into affiliations' affiliations, etc.) and merge as is. - Implement a dedicated affiliation (entity-like) object without: dates, affiliation, (orcid). In the context of such a new class, discussions around introducing insitutional levels (institute, dept., etc.) may be had, but aren't necessarily where we would want to go.
Would this new multiple affiliation class allow for
(note that the first affiliation has no I would expect
see the full See the rendered version on Zenodo: https://zenodo.org/records/10648000 which includes the Currently this is impossible, so I have to maintain the data in two places at once. I am unsure as to whether this PR would support this. If not, I would say it's incomplete, as this is a major use case. |
Thanks @alexlancaster for this input!
Yes, RORs for entities have been introduced into the schema with #484 and will be part of CFF 1.3.0.
I suggest to track this in the |
Yes I did see that, I just wanted to be sure that
Will do. |
Related issues
Refs:
Describe the changes made in this pull request
This PR changes the schema such that it can accommodate authors with multiple affiliations. Under this PR, the following would be valid:
These examples are for an entity author, but it works the same for person authors.
For the record, I don't see much added value of allowing entity and array of entity and string and array of string, compared to allowing just string and array of string. But there is a real cost for implementers and maintainers of tooling (cffconvert, cffinit), which for a project that has been ran on fumes might not be a sustainable choice.
Review checklist
(format/schema/semantic documentation changes:
develop
; typos, meta files, etc.:main
)CHANGELOG.md
and adapt if necessary.<do other things>