Add non-breaking space to AD/BC terms in de-DE locale

[tillheilmann]

Added (non-breaking) space to terms "ad" and "bc"

[csl-bot]

Awesome! You've created a pull request to the Citation Styles Language locales repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your locale file validates.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

[csl-bot]

Yay! Your pull request passed all our automated tests. We'll take a look soon.

[adam3smith]

@rmzelle -- just want to confirm with you that you agree this is right in the locale (I told Till it is): The English 40bc is 40 v. Chr. in German, so it makes sense to me to code the space into the term.

[rmzelle]

@adam3smith, do most style guides not use a separating space? E.g. https://en.wikipedia.org/wiki/Anno_Domini does ("AD 525" and "1 BC")

@tillheilmann, have you confirmed that this change actually works? (in Zotero, Mendeley, or something else)

[adam3smith]

you're right. Chicago Manual adds a space, too. @fbennett do you have any recollection on why citeproc-js doesn't add a space between year and BC/AD terms?

[rmzelle]

do you have any recollection on why citeproc-js doesn't add a space between year and BC/AD terms?

Maybe because we wrote it that way in the spec? :)

http://docs.citationstyles.org/en/stable/specification.html#ad-and-bc says

The “ad” term (Anno Domini) is automatically appended to positive years of less than four digits (e.g. “79” becomes “79AD”). The “bc” term (Before Christ) is automatically appended to negative years (e.g. “-2500” becomes “2500BC”).

As long as the CSL processors don't trim white-space characters defined in the term definitions, this is probably the right solution, since it allows for the choice between regular and non-breaking delimiting spaces, as proposed in this PR.

[adam3smith]

good point -- we're taking these then, yes?

[rmzelle]

Could wait for Frank to chime in, but otherwise yes.

[tillheilmann]

@rmzelle, the change of terms (with added non-breaking spaces) works for me if I redefine the terms in the header of my custom CSL files and produce output with Zotero (4.0) on my Mac. I have not tried other versions/programs/OSs.

[rmzelle]

Thanks!