New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translators from git log to the locale files. #173
Add translators from git log to the locale files. #173
Conversation
For all xml files without any <translator> tag, the authors of the commits were extracted from git log, and the ones from technical commits / mass commits over the whole repo manually removed. The rest were added as <translator>s to the xml files.
Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your locale file validates. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
Any idea why you weren't able to pull up translators for these files? Looks like e.g. "af-ZA" was created all the way back before we were using Git (in the SVN at https://sourceforge.net/p/xbiblio/code/HEAD/tree/attic/csl/locales/). I guess that might hold for the other files as well, but I haven't checked. |
Also, while I'm not opposed to this, I don't think we should be adding people's email addresses. I know they're already public as part of the Git commit history, but adding them to the locales files might further increase the amount of spam people get, and users of the locale files might also start emailing these translators for support which might not be appreciated. (e.g. personally I rather not have my email address in these files) |
As for the missing translators: As for email addresses: |
Right, but we never ask people to include their email addresses, so in that case it's entirely their decision. Could you remove them? |
as the persons did not include them themselves.
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
On Thu, 28 Dec 2017 21:36:51 -0800, Rintze M. Zelle wrote:
Right, but we never ask people to include their email addresses, so
in that case it's entirely their decision. Could you remove them?
Sure, committed and pushed.
|
Also eliminate a duplicate
(created a PR with some small fixes: gregoa#1) |
On Fri, 29 Dec 2017 10:07:18 -0800, Rintze M. Zelle wrote:
(created a PR with some small fixes)
Thanks! Merged in my branch.
…--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Eric Clapton: Rollin' & Tumblin'
|
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
Yay! Your pull request passed all our automated tests. We'll take a look soon. |
@adam3smith, looks good to squash and merge to me. Okay with this? |
@adam3smith, bump for your review. |
Sorry, I hadn't seen you were waiting for me on this. Thanks everyone! |
On Sun, 21 Jan 2018 04:38:01 +0000, Sebastian Karcher wrote:
Sorry, I hadn't seen you were waiting for me on this. Thanks everyone!
Thanks for merging, and everyone for their help!
Cheers,
gregor
…--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Dire Straits: Lions
|
For all xml files without any
<translator>
tag, the authors of the commitswere extracted from git log, and the ones from technical commits / mass
commits over the whole repo manually removed. The rest were added as
<translator>
s to the xml files.Background: issue #151
This still leaves 8 files without any
<translator>
s: