Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translators from git log to the locale files. #173

Merged
merged 9 commits into from Jan 21, 2018

Conversation

gregoa
Copy link
Contributor

@gregoa gregoa commented Dec 29, 2017

For all xml files without any <translator> tag, the authors of the commits
were extracted from git log, and the ones from technical commits / mass
commits over the whole repo manually removed. The rest were added as
<translator>s to the xml files.

Background: issue #151
This still leaves 8 files without any <translator>s:

locales-af-ZA.xml
locales-bg-BG.xml
locales-cy-GB.xml
locales-km-KH.xml
locales-ko-KR.xml
locales-mn-MN.xml
locales-sr-RS.xml
locales-uk-UA.xml

For all xml files without any <translator> tag, the authors of the commits
were extracted from git log, and the ones from technical commits / mass
commits over the whole repo manually removed. The rest were added as
<translator>s to the xml files.
@csl-bot
Copy link
Contributor

csl-bot commented Dec 29, 2017

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link
Contributor

csl-bot commented Dec 29, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle
Copy link
Member

rmzelle commented Dec 29, 2017

This still leaves 8 files without any s:

Any idea why you weren't able to pull up translators for these files? Looks like e.g. "af-ZA" was created all the way back before we were using Git (in the SVN at https://sourceforge.net/p/xbiblio/code/HEAD/tree/attic/csl/locales/). I guess that might hold for the other files as well, but I haven't checked.

@rmzelle
Copy link
Member

rmzelle commented Dec 29, 2017

Also, while I'm not opposed to this, I don't think we should be adding people's email addresses. I know they're already public as part of the Git commit history, but adding them to the locales files might further increase the amount of spam people get, and users of the locale files might also start emailing these translators for support which might not be appreciated.

(e.g. personally I rather not have my email address in these files)

@gregoa
Copy link
Contributor Author

gregoa commented Dec 29, 2017

As for the missing translators:
git log --format=short locales-af-ZA.xml doesn't show any commit which is related to any translation / specific to this files, just generic updates which affected all/most xml files. I also had a brief look at svn, but e.g. svn log locales-af-ZA.xml also doesn't give the impression of actual translators' work (though I haven't checked the commits themselves, just the log. Also because I mostly forgot how to use svn :))

As for email addresses:
Some of the existing entries have them but not many, I was mostly following the example of the styles.git repo where many of the author/contributor entries have email addresses -- but I'm happy to leave them out as well.

@rmzelle
Copy link
Member

rmzelle commented Dec 29, 2017

I was mostly following the example of the styles.git repo where many of the author/contributor entries have email addresses -- but I'm happy to leave them out as well.

Right, but we never ask people to include their email addresses, so in that case it's entirely their decision. Could you remove them?

@csl-bot
Copy link
Contributor

csl-bot commented Dec 29, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@gregoa
Copy link
Contributor Author

gregoa commented Dec 29, 2017 via email

@rmzelle
Copy link
Member

rmzelle commented Dec 29, 2017

(created a PR with some small fixes: gregoa#1)

@gregoa
Copy link
Contributor Author

gregoa commented Dec 30, 2017 via email

@csl-bot
Copy link
Contributor

csl-bot commented Dec 30, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@csl-bot
Copy link
Contributor

csl-bot commented Dec 30, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@csl-bot
Copy link
Contributor

csl-bot commented Dec 30, 2017

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle
Copy link
Member

rmzelle commented Dec 30, 2017

@adam3smith, looks good to squash and merge to me. Okay with this?

@koppor
Copy link
Contributor

koppor commented Jan 18, 2018

May I ask whether this can be merged?

I think, this PR also relates somehow with the branch pr/172. Think, this has to go in first, then the updates by @rmzelle?

To ensure that future contributions contain the correct attributions, I created an initial contributing guideline at #174.

@rmzelle
Copy link
Member

rmzelle commented Jan 21, 2018

@adam3smith, bump for your review.

@adam3smith adam3smith merged commit 15396c0 into citation-style-language:master Jan 21, 2018
@adam3smith
Copy link
Member

Sorry, I hadn't seen you were waiting for me on this. Thanks everyone!

@gregoa
Copy link
Contributor Author

gregoa commented Jan 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants