CSL JSON: date-parts set minItems to 1

Currently, the JSON Schema allows empty arrays in date-parts, which can cause downstream citeproc utilities to crash. See manubot/manubot#66 Set minItems to 1 for the date-parts array as well as the nested arrays with year, month, day info.
citation-style-language · May 21, 2020 · 6bbb80b · 6bbb80b
1 parent 7179185
commit 6bbb80b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/csl-data.json b/csl-data.json
@@ -206,8 +206,10 @@
                                             "number" 
                                         ] 
                                     },
+                                    "minItems": 1,
                                     "maxItems": 3 
                                 },
+                                "minItems": 1,
                                 "maxItems": 2 
                             },
                             "season": {

diff --git a/tests/test_json.py b/tests/test_json.py
@@ -91,3 +91,18 @@ def test_data_schema_with_extra_property_fails(csl_data_validator):
     }]
     with pytest.raises(jsonschema.exceptions.ValidationError):
         csl_data_validator.validate(csl)
+
+def test_data_schema_with_empty_date_parts(csl_data_validator):
+    """
+    empty arrays in date-parts can cause downstream citeproc failures
+    https://github.com/citation-style-language/schema/pull/158
+    """
+    csl = [{
+        'id': 'example-id',
+        'type': 'report',
+        'issued': {
+            "date-parts": []
+        },
+    }]
+    with pytest.raises(jsonschema.exceptions.ValidationError):
+        csl_data_validator.validate(csl)