Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLOS style references include publisher for journal articles #4140

Closed
dhimmel opened this issue Jun 11, 2019 · 4 comments · Fixed by #4191
Closed

PLOS style references include publisher for journal articles #4140

dhimmel opened this issue Jun 11, 2019 · 4 comments · Fixed by #4191

Comments

@dhimmel
Copy link

dhimmel commented Jun 11, 2019

PLOS Computational Biology (and PLOS) show an example journal article reference of:

  1. Hou WR, Hou YL, Wu GF, Song Y, Su XL, Sun B, et al. cDNA, genomic sequence cloning and overexpression of ribosomal protein gene L9 (rpL9) of the giant panda (Ailuropoda melanoleuca). Genet Mol Res. 2011;10: 1576-1588.

  2. Devaraju P, Gulati R, Antony PT, Mithun CB, Negi VS. Susceptibility to SLE in South Indian Tamils may be influenced by genetic selection pressure on TLR2 and TLR9 genes. Mol Immunol. 2014 Nov 22. pii: S0161-5890(14)00313-7. doi: 10.1016/j.molimm.2014.11.005.

Note that publisher information is not included (at least when container-title is known). However, we find here that the publisher is included (in this case "Oxford University Press"):

  1. Khare R, Good BM, Leaman R, Su AI, Lu Z. Crowdsourcing in biomedicine: challenges and opportunities. Brief Bioinform. Oxford University Press; 2016;17: 23–32. doi:10.1093/bib/bbv021

The CSL for this item is:

  {
    "source": "PubMed",
    "accessed": {
      "date-parts": [
        [
          2019,
          4,
          4
        ]
      ]
    },
    "id": "12sHvZy1a",
    "title": "Crowdsourcing in biomedicine: challenges and opportunities",
    "author": [
      {
        "family": "Khare",
        "given": "Ritu"
      },
      {
        "family": "Good",
        "given": "Benjamin M"
      },
      {
        "family": "Leaman",
        "given": "Robert"
      },
      {
        "family": "Su",
        "given": "Andrew I"
      },
      {
        "family": "Lu",
        "given": "Zhiyong"
      }
    ],
    "container-title-short": "Brief Bioinform",
    "container-title": "Briefings in bioinformatics",
    "publisher": "Oxford University Press",
    "ISSN": "1467-5463",
    "issued": {
      "date-parts": [
        [
          2016,
          1
        ]
      ]
    },
    "page": "23-32",
    "volume": "17",
    "issue": "1",
    "PMID": "25888696",
    "PMCID": "PMC4719068",
    "DOI": "10.1093/bib/bbv021",
    "type": "article-journal",
    "URL": "https://www.ncbi.nlm.nih.gov/pmc/articles/PMC4719068/",
    "note": "This CSL JSON Item was automatically generated by Manubot v0.2.3 using citation-by-identifier.\nstandard_id: pmcid:PMC4719068"
  },

Is it possible for the following to be conditional, in a way that would omit showing publisher when type is article-journal and container-title is available:

styles/plos.csl

Line 305 in 76e2ff8

<text macro="publisher"/>

@bwiernik
Copy link
Member

bwiernik commented Jul 2, 2019

I wouldn’t pay any attention to that example. Journal articles in PLOS journals don’t generally, if ever, include publishers. There is no reason for the inconsistency in the examples here.

Note that container-title is the title of the journal, so the conditional you propose would always be true.

@adam3smith
Copy link
Member

@bwiernik -- I don't understand (or maybe you're misreading the issue -- the example with publisher is not from PLOS but from our style for PLOS).
It's not uncommon for journal article metadata to include the publisher (pubmed, CrossRef). In some countries (such as Brazil) it's even included in the citation. The problem is that our styles have assumed for a very long time the Zotero data model which doesn't have a publisher for journal articles and so we're getting this.

I'd add a much more general publisher conditional that removes it entirely from journal, magazine, and newspaper articles (at a minimum)

@bwiernik
Copy link
Member

bwiernik commented Jul 2, 2019

Yes, that’s right. Sorry—I misread the issue as quoting example citations.

@dhimmel
Copy link
Author

dhimmel commented Sep 26, 2019

Cleaning up old GitHub notification emails. Thanks @POBrien333 for resolving this in #4191.

Noting that we've encountered some additional issues with the PLOS CSL style, described at #4138 and greenelab/meta-review#241 (comment). Some of the issues like including [Preprint] after the preprint repository name are likely not possible given the current types supported by CSL Data Items.

Ideally journals would produce the styles themselves and use it as the reference implementation of how the styles should behave. But until then, thanks to volunteers like @POBrien333 and @adam3smith for doing the hard work!

POBrien333 added a commit to POBrien333/styles that referenced this issue Sep 27, 2019
Fix issues regarding [internet] and [preprint] for PLoS as per: citation-style-language#4138 (and pointed out again here: citation-style-language#4140 (comment))

Please check carefully if I did this correctly. :)
adam3smith added a commit that referenced this issue Oct 2, 2019
* Update plos.csl

Fix issues regarding [internet] and [preprint] for PLoS as per: #4138 (and pointed out again here: #4140 (comment))

Please check carefully if I did this correctly. :)

* Update plos.csl

* Update plos.csl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants