Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-stellenbosch-university.csl #2944

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

Yusufras
Copy link
Contributor

No description provided.

<text macro="author-short"/>
        <text macro="year-date"/>
@csl-bot
Copy link

csl-bot commented Sep 13, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Sep 13, 2017

😟 There are some issues with your submission. Please check the test report for details.

@@ -203,7 +203,7 @@
<layout prefix="(" suffix=")" delimiter="; ">
<group delimiter=", ">
<text macro="author-short"/>
<text macro="date-issued-no-parentheses"/>
<text macro="year-date"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've now called a macro (year-date) that does not exist and therefor it is giving you an error.
What are you trying to accomplish?

@Yusufras
Copy link
Contributor Author

Yusufras commented Sep 13, 2017 via email

@POBrien333
Copy link
Contributor

@Yusufras
You can just switch lines 200 and 201 with each other.
Structure wise your in the "citation" part and in that in the "sort" part of the style. Just for your orientation :)

     Changed:
 <key macro="author"/>
      <key macro="date-issued-no-parentheses"/>
@csl-bot
Copy link

csl-bot commented Sep 13, 2017

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit b2591f0 into citation-style-language:master Sep 13, 2017
@adam3smith
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants