Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ecological-restoration.csl #2971

Merged
merged 2 commits into from
Sep 27, 2017

Conversation

POBrien333
Copy link
Contributor

@csl-bot
Copy link

csl-bot commented Sep 21, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot
Copy link

csl-bot commented Sep 21, 2017

😃 Your submission passed all our automated tests.

<choose>
<if type="article-journal article-magazine article-newspaper" match="any">
<choose>
<if match="all" variable="page issued">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are "page issued" really the best variables here? Wouldn't "page volume" make more sense here?

</group>
</layout>
</citation>
<bibliography entry-spacing="0" hanging-indent="true" delimiter-precedes-last="contextual">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the delimiter-precedes-last here: it doesn't do anything (as this is the default) and this isn't a good place to set it, either.

<text variable="volume" prefix=" "/>
<text variable="page" prefix=":"/>
</if>
<else>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You almost certainly would still want the container-title for early publication items, right?

@adam3smith
Copy link
Member

A couple of small comments/questions above (sorry for the multiple notifications, I thought I just had one & wasn't going to use review mode but then spotted a couple of other potential issues).

@rmzelle
Copy link
Member

rmzelle commented Sep 26, 2017

(metadata looks good to me)

Thanks for the edit suggestions. Remnants from the template style.
@csl-bot
Copy link

csl-bot commented Sep 26, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 92e1073 into citation-style-language:master Sep 27, 2017
@rmzelle
Copy link
Member

rmzelle commented Sep 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants