-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the AMA base style to properly reference presentations #3274
Conversation
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. |
😟 There are some issues with your submission. Please check the test report for details. |
american-medical-association.csl
Outdated
@@ -215,6 +219,20 @@ | |||
<else-if type="webpage"> | |||
<text variable="container-title" prefix=" " suffix="."/> | |||
</else-if> | |||
<else-if type="speech"> | |||
<group delimiter=" "> | |||
<text variable="genre" prefix=" " suffix=" presented at:"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use <text term="presented at" suffix=":"/>
instead to keep the style localizable to non-English.
We should also think about some different scenarios here, i.e. what if genre is not present? What if event is missing (less likely)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I hadn't considered the different cases of omitted information. There is no AMA recommendation in these cases but I suppose we can exercise some judgement to make it fail more gracefully. I'll edit this with these considerations and your other suggestion regarding non-English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, just make sure it looks reasonable, especially when genre
is missing, as it often will.
…orrect terms, perhaps a locale problem?
update with master to continue working
😟 There are some issues with your submission. Please check the test report for details. |
😟 There are some issues with your submission. Please check the test report for details. |
😃 Your submission passed all our automated tests. |
Thanks -- I simplified the logic for presentations without event a bit more (note, btw., that you cannot use random terms, they need to be in the specifications) |
Mmm yeah I realized that as I was familiarizing myself with CSL more. The failure case where the conference name is omitted isn't graceful in my opinion. It leaves the Thanks for all your help. |
speech
is the CSL type which seems most fitting for orally presented work at a conference.genre
holds the type presented. The AMA style guide gives examples of types as "posters" or "papers".event
,event-place
anddate
hold the name, location and date of the conference.an example of a properly rendered presentation from the AMA style guide: