Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bibliotheque-universitaire-de-medecine-vancouver.csl #4059

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

alerac
Copy link
Contributor

@alerac alerac commented Apr 24, 2019

  • Added "note" variable to "webpage" document type to take
    into account the date of the webpage (not website) if any
    is present in the "Extra" field of Zotero.

* Added "note" variable to "webpage" document type to take
  into account the date of the webpage (not website) if any
  is present in the "Extra" field of Zotero.
@csl-bot
Copy link

csl-bot commented Apr 24, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link

csl-bot commented Apr 24, 2019

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

No, I removed that for a reason - relying on note is generally a bad idea. People store all types of things in the Extra field in Zotero and once you move to other reference managers, you'll get all sorts of weird stuff. Could you clarify what date exactly this is supposed to capture? I couldn't quite follow the distinction.

@alerac
Copy link
Contributor Author

alerac commented Apr 25, 2019

No, I removed that for a reason - relying on note is generally a bad idea. People store all types of things in the Extra field in Zotero and once you move to other reference managers, you'll get all sorts of weird stuff. Could you clarify what date exactly this is supposed to capture? I couldn't quite follow the distinction.

Hi, Ok I see the problem.

Actually in the Vancouver guide (following the Vancouver recommendations) that we provide at the library (link here), P. 23 we say that if the date of the website (globally) and the date of the webpage (content of the website) are present then the students can mention it in the reference.

webpage_webiste_date

However, Zotero does not make a distinction between webpage and website (there is only a "Webpage" document type) and only one "Date" field is available.

So I thought it might be worthwhile to manage the second date with the "Extra" field. But I really understand your point and it is better no to stray from the standard.

I will correct again and not take into account the webpage date.

Thank you for your explanation!

* Removed "note" variable to "webpage" document type
* Modified suffix from Semicolon to Space for "title" variable
@csl-bot
Copy link

csl-bot commented Apr 25, 2019

😃 Your submission passed all our automated tests.

@alerac
Copy link
Contributor Author

alerac commented Apr 25, 2019

Hi,
I removed the "note" variable and corrected the suffix for the "title" variable. It is ok on my side, no more corrections to do at this point.
Thanks for the help.
Best,
Alex

@rmzelle rmzelle merged commit 5d7b966 into citation-style-language:master Apr 26, 2019
@rmzelle
Copy link
Member

rmzelle commented Apr 26, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants