Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chinese-law-journals.csl #5314

Merged
merged 4 commits into from
Mar 15, 2021

Conversation

redleafnew
Copy link
Contributor

More reference types needed to test the style, anyone could contact redleafnew@163.com.

More reference types needed to test the style, anyone could contact redleafnew@163.com.
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@redleafnew redleafnew changed the title Create chinese-law-journals-sub.csl Create chinese-law-journals.csl Mar 10, 2021
@github-actions
Copy link

😟 There are some issues with your submission.

2 tests failed

chinese-law-journals-sub: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[26, "26:0: ERROR: Did not expect element locale there"], [26, "26:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

chinese-law-journals-sub: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/chinese-law-journals-sub"
     got: "http://www.zotero.org/styles/chinese-law-journals"

(compared using ==)

Please check the test report for details.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

chinese-law-journals: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[26, "26:0: ERROR: Did not expect element locale there"], [26, "26:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

Copy link
Contributor Author

@redleafnew redleafnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@redleafnew
Copy link
Contributor Author

I have changed the lines.

@adam3smith
Copy link
Member

Don't worry about the test failure.

Could you say a bit more about this style? What is it based on? Which journals would use it? We typically would accept styles specific to one journal rather than something as sweeping as "Chinese Law Journals"

@retorquere -- this looks like it might fail because of the rename within the pull request?

@redleafnew
Copy link
Contributor Author

Many Chinese law journals and publishers apply this style, such China Legal Science, China Law Review (http://www.chinalawreview.com.cn), Peking University Law (http://journal.pkulaw.cn/NewIssue/Detail/160073), Journal of Comparative Law (https://bjfy.cbpt.cnki.net/WKC/WebPublication/index.aspx?mid=bjfy). https://www.weibo.com/ttarticle/p/show?id=2309404436112734027798 aslo lists some journal and publishers.

It is based on http://www.zotero.org/styles/china-national-standard-gb-t-7714-2015-note.

@retorquere
Copy link
Collaborator

Sheldon didn't know to look at the pull-request directory 🤦 . If you re-start the action on this PR, it should pull in the fixed sheldon and should pass.

@redleafnew
Copy link
Contributor Author

thanks @retorquere , and how to re-start the action on this PR?

@retorquere
Copy link
Collaborator

@redleafnew you can't, only a repo owner can.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

chinese-law-journals.csl (new)
《Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy》,载HANCKÉ B, RHODES M, THATCHER M, 编. ,Oxford University Press2007年版; 《CSL search by example》,2012年,http://editor.citationstyles.org/searchByExample/,2012年12月15日访问。
MARES I:《Firms and the welfare state: When, why, and how does social policy matter to employers?》,载HALL P A, SOSKICE D, 编//《Varieties of capitalism. The institutional foundations of comparative advantage》,Oxford University Press2001年版: 184–213; FENNER M, CROSAS M, GRETHE J S, 等:《A data citation roadmap for scholarly data repositories》:载《Scientific Data》2019年第1期第28页。

〔1〕《Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy》,载HANCKÉ B, RHODES M, THATCHER M, 编. ,Oxford University Press2007年版。
〔2〕《CSL search by example》,2012年,http://editor.citationstyles.org/searchByExample/,2012年12月15日访问。
〔3〕MARES I:《Firms and the welfare state: When, why, and how does social policy matter to employers?》,载HALL P A, SOSKICE D, 编//《Varieties of capitalism. The institutional foundations of comparative advantage》,Oxford University Press2001年版: 184–213。
〔4〕FENNER M, CROSAS M, GRETHE J S, 等:《A data citation roadmap for scholarly data repositories》:载《Scientific Data》2019年第1期第28页。

@redleafnew
Copy link
Contributor Author

Many thanks.

@adam3smith
Copy link
Member

OK, I now understand that this is based on the style guide here: https://colr.xmu.edu.cn/_upload/article/files/67/3c/bdf817f64039947a52276727ef01/082c41aa-fed1-4460-97fa-7f471901a879.pdf endorsed by a number of legal associations and journals.
I am wondering if we could come up with a better name, though? "Chinese Law Journals" sounds very generic. The corresponding English styles have pretty recognizable names like "Bluebook" (US), "Australian Guide for Legal Citation" (Australia), "McGill Guide" (Canada), etc.
Would it make sense to just use a transliterated version of the title, something like "fǎxué yǐn zhù shǒucè" (I used automated transliteration, hope that's right)? Or is there a more specific English translation we could come up with, maybe based on the main sponsoring association?

@rmzelle
Copy link
Member

rmzelle commented Mar 12, 2021

@adam3smith, I don't think we ever use transliteration in style titles (although a slugified transliterated title would probably make the most sense for the style ID).

I did find a section at https://weibo.com/ttarticle/p/show?id=2309404436112734027798 discussing the name of the style (search for "(6) The name of this citation style" after Google Translate).

@redleafnew, would 法学引注手册 be a good name for the style ("Law Citation Manual")? Or should we also mention the connected institution? It looks like this style is curated by the Law Journal Research Association of the Chinese Law Society?

@redleafnew
Copy link
Contributor Author

redleafnew commented Mar 12, 2021 via email

@rmzelle
Copy link
Member

rmzelle commented Mar 14, 2021

We'd probably name the style either "Law Citation Manual (中文)" or "法学注引手册 (中文)", whatever you think makes the style easiest to find for its users.

@redleafnew
Copy link
Contributor Author

Could we use the name 'Law Citation Manual (中法学注引手册, 中文)'?

@adam3smith
Copy link
Member

Yes, I was going to say that I like the idea of having both translation and original available

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

law-citation-manual.csl (new)
《Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy》,载HANCKÉ B, RHODES M, THATCHER M, 编. ,Oxford University Press2007年版; 《CSL search by example》,2012年,http://editor.citationstyles.org/searchByExample/,2012年12月15日访问。
MARES I:《Firms and the welfare state: When, why, and how does social policy matter to employers?》,载HALL P A, SOSKICE D, 编//《Varieties of capitalism. The institutional foundations of comparative advantage》,Oxford University Press2001年版: 184–213; FENNER M, CROSAS M, GRETHE J S, 等:《A data citation roadmap for scholarly data repositories》:载《Scientific Data》2019年第1期第28页。

〔1〕《Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy》,载HANCKÉ B, RHODES M, THATCHER M, 编. ,Oxford University Press2007年版。
〔2〕《CSL search by example》,2012年,http://editor.citationstyles.org/searchByExample/,2012年12月15日访问。
〔3〕MARES I:《Firms and the welfare state: When, why, and how does social policy matter to employers?》,载HALL P A, SOSKICE D, 编//《Varieties of capitalism. The institutional foundations of comparative advantage》,Oxford University Press2001年版: 184–213。
〔4〕FENNER M, CROSAS M, GRETHE J S, 等:《A data citation roadmap for scholarly data repositories》:载《Scientific Data》2019年第1期第28页。

@rmzelle rmzelle merged commit 4582cb6 into citation-style-language:master Mar 15, 2021
@rmzelle
Copy link
Member

rmzelle commented Mar 15, 2021

@redleafnew, thanks!

@redleafnew
Copy link
Contributor Author

@rmzelle Sorry, the Chinese name should be 法学注引手册, 中文 or 中国法学注引手册, 中文 instead of 中法学注引手册, 中文 in the bracket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants