-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deutsche-gesellschaft-fur-psychologie.csl #5861
Conversation
I needed this citation style to work with translated works, which was not implemented in the current version. I added this functionality to the style for Deutsche Gesellschaft für Psychologie. I also took the liberty to update some references, since the link to the 4th edition was not working. I cannot tell if the citation rules for translated books or classic works are the same in the 4th edition. The rest of the citation style is compatible and compliant with the 5th edition, so I assume this was safe to update. I have impelemented two cases: 1) classic works 2) translated works They are being cited differently and the bibliography entry looks slightly different for these two cases. I decided to use the "translator" variable to distignuisch the two cases, I assumed this would be safe.
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😟 There are some issues with your submission. 1 test faileddeutsche-gesellschaft-fur-psychologie.csl Please check the test report for details. |
(The test shouldn't fail -- I think it just expects the parentheses at the end of the title) |
Change the title so the expression in parantheses is at the end of it. Therefore placed the edition information in front of the parantheses.
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: deutsche-gesellschaft-fur-psychologie.csl (modified style; unchanged output for sample items)(„CSL search by example“, 2012; Hancké, Rhodes & Thatcher, 2007) |
I revisited and reread the manual regarding the translations and classical works and made one more correction to the file. The citation is, from my understanding, in both cases original-date/issued-date. I refer to the pages 108, 123 and 127 in the DGP style manual (5th edition).
That last commit changes the output behavior. Can you give an example of what a reference with a translator is supposed to look like so I can understand? |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: deutsche-gesellschaft-fur-psychologie.csl (modified style; unchanged output for sample items)(„CSL search by example“, 2012; Hancké, Rhodes & Thatcher, 2007) |
Sorry for the confusion @bwiernik. The citation and bibliography entry for a translated book would look like this (From the manual, p. 123): bibliography: Citation in the text: |
Co-authored-by: Brenton M. Wiernik <bwiernik@users.noreply.github.com>
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: deutsche-gesellschaft-fur-psychologie.csl (modified style; unchanged output for sample items)(„CSL search by example“, 2012; Hancké, Rhodes & Thatcher, 2007) |
Implementing CSL 1.0.2 term "original-work-published"
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: deutsche-gesellschaft-fur-psychologie.csl (modified style; unchanged output for sample items)(„CSL search by example“, 2012; Hancké, Rhodes & Thatcher, 2007) |
Updated the CSL to make sure, that the the bibliography entry will only contain the part ": original title" if 1) a translator is specified and 2) an original title is specified.
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: deutsche-gesellschaft-fur-psychologie.csl (modified style; unchanged output for sample items)(„CSL search by example“, 2012; Hancké, Rhodes & Thatcher, 2007) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output (in-text reference as well as bibliography entry) are now correct. If the variable original-date is given, both dates will be displayed. If a translator is specified AND the variable original-title is given, the original title will also be shown in the bibliography (this is not mandatory, but both ways are ok with DGP). Hogrefe Verlag confirmed my interpretation of the manual so I would leave the final choice to the end-user.
@bwiernik leaving this one for you to review and merge |
Thanks! |
I needed this citation style to work with translated works, which was not implemented in the current version. I added this functionality to the style for Deutsche Gesellschaft für Psychologie.
I also took the liberty to update some references, since the link to the 4th edition was not working. I cannot tell if the citation rules for translated books or classic works are the same in the 4th edition. The rest of the citation style is compatible and compliant with the 5th edition, so I assume this was safe to update.
I have impelemented two cases:
They are being cited differently and the bibliography entry looks slightly different for these two cases. I decided to use the "translator" variable to distignuisch the two cases, I assumed this would be safe.