Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dedicated Basque APA file #6370

Merged
merged 10 commits into from Jun 26, 2023

Conversation

mirenbz
Copy link
Contributor

@mirenbz mirenbz commented Jan 12, 2023

Basque requires the order of some elements to be changed. This is not possible to localize and have in a single file, as I was explained in the official forums. That's why I'm proposing this dedicated APA file for Basque that fixes the order of some elements that are currently wrong for Basque.

I have also made some corrections in the specific locale to match: citation-style-language/locales@cc60270

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

apa-eu: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/apa-eu"
     got: "http://www.zotero.org/styles/apa"

(compared using ==)

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-eu.csl (new)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.

@bwiernik
Copy link
Member

Could you add a comment before line 30 of the style detailing the changes that are made for Basque localization here?

(Like what is already there about item types and the basic APA structure)

That will help me in two ways:

  1. I will be able to keep this style up to date with changes to the main APA.CSL
  2. If features become available that make the separate style file unnecessary because the localization needs are built into the processor, we can retire the separate style

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 12, 2023
@mirenbz
Copy link
Contributor Author

mirenbz commented Jan 12, 2023

Done!

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jan 12, 2023
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-eu.csl (new)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-eu.csl (new)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-eu.csl (new)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. p. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (184–213. pp.). Oxford University Press.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-eu.csl (new)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M. and Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. p. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M. and Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (184–213. pp.). Oxford University Press.

@adam3smith adam3smith merged commit ac0afa3 into citation-style-language:master Jun 26, 2023
1 check passed
@adam3smith
Copy link
Member

Thanks & sorry for the delay

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants