Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create etudes-francaises.csl #6694

Merged
merged 12 commits into from
Mar 17, 2024
Merged

Create etudes-francaises.csl #6694

merged 12 commits into from
Mar 17, 2024

Conversation

loup-brun
Copy link
Contributor

@loup-brun loup-brun commented Sep 14, 2023

Checks, as per the style requirements:

  • Title Abbreviations Études françaises, ETFRA
  • Title Diacritics “É” and “ç” retained
  • Style Locale default fr-CA
  • File Name etudes-francaises.csl
  • Style ID http://www.zotero.org/styles/etudes-francaises
  • "self" Link http://www.zotero.org/styles/etudes-francaises
  • License CC BY-SA 3.0
  • "template" Link http://www.zotero.org/styles/bulletin-de-correspondance-hellenique
  • ISSN and eISSN 0014-2085 1492-1405
  • "documentation" Link https://revue-etudesfrancaises.umontreal.ca/wp-content/uploads/2023/02/protocole-de-redaction.pdf
  • XML Indentation 2 spaces
  • Validation validated against the CSL schema through the online validator

Other TODOs:

  • Test against all examples provided in PDF documentation (last updated 2021, see date in PDF documentation).
  • Set last updated to correct datetime before merging.

I maintain the individual style here (with some tests), in an upstream Git repository:

@loup-brun loup-brun changed the title add etudes-francaises.csl Create etudes-francaises.csl Sep 14, 2023
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

etudes-francaises: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "ERROR: Extra element uri in interleave"], [12, "12:0: ERROR: Element author failed to validate ...ment info failed to validate content"], [2, "2:0: ERROR: Element style failed to validate content"]].empty?` to be truthy, got false

Please check the test report for details.

esp. for thesis (volume, pages)

fix match="any" on some choose type
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

etudes-francaises: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "ERROR: Extra element uri in interleave"], [12, "12:0: ERROR: Element author failed to validate ...ment info failed to validate content"], [2, "2:0: ERROR: Element style failed to validate content"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ (page consultée le 15 décembre 2012).
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Sci. Data, vol. 6, nᵒ 1, 2019, p. 28, disponible en ligne : http://www.nature.com/articles/s41597-019-0031-8 (page consultée le 27 avril 2019).

« CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ (page consultée le 15 décembre 2012).
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Sci. Data, vol. 6, nᵒ 1, 2019, p. 28, disponible en ligne : http://www.nature.com/articles/s41597-019-0031-8 (page consultée le 27 avril 2019).
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

etudes-francaises.csl Outdated Show resolved Hide resolved
* Display normal journal name (not short)

* Support rendering DOI rather than URL (DOI is preferred by ETUFRA)

* Accessed with semi-colon separator (not between parentheses,
  as per latest documentation)

* Improve delimiters

* Update timestamp
@github-actions
Copy link

😟 There are some issues with your submission.

1 test failed

etudes-francaises: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[8, "8:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [24, "24:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. 6, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. 6, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

number-of-volumes: roman form for thesis
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

fix op. cit. (fallback for all other types, e.g. thesis, report, book...
that do not use loc. cit.)
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

* pages => p. (conflicting examples in documentation, settling
for p.)

* updated timestamp
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne :http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

* fix edge case missing delimiter spacing for "available online:"
  (working fine with DOI, but sometimes space disappears
  for URL)

* update timestamp
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

@bwiernik
Copy link
Member

bwiernik commented Oct 1, 2023

Thanks! This looks great. One question, does the journal just publish in French, or in both French and English? If both, please remove the default locale

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 1, 2023
@loup-brun
Copy link
Contributor Author

Hi @bwiernik, the journal publishes exclusively in French, hence the default locale.

@loup-brun loup-brun marked this pull request as ready for review October 2, 2023 12:56
@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 2, 2023
@loup-brun
Copy link
Contributor Author

This PR is ready for review.

@bwiernik
Copy link
Member

bwiernik commented Oct 2, 2023

Could you remove the en locale section in the the style since it's not needed? Otherwise this looks great

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 2, 2023
@loup-brun
Copy link
Contributor Author

loup-brun commented Oct 3, 2023

@bwiernik the journal Études françaises indeed publishes only French-language works; however, the University of Montreal Press (PUM) also uses this bibliographic style (this is mentioned in the upstream Git repository where the style is maintained individually, in French). The PUM occasionally publishes books in English; and since it is common here in Montréal, Canada, to publish in either language, I intentionally kept the English locale defs for consistency.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 3, 2023
* fix locale fr loc. cit.

* update timestamp
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

loup-brun added a commit to loup-brun/csl-etudes-francaises that referenced this pull request Oct 23, 2023
il semblerait que ce ne sera jamais intégré sinon...
citation-style-language/styles#6694

le maintainer ne veut pas de locale "en", car selon lui ce ne serait
"pas nécessaire" ("since it's not needed")'
Remove "en" locale, as per CSL maintainer's comment
@loup-brun
Copy link
Contributor Author

loup-brun commented Oct 23, 2023

HI @bwiernik, I have removed the en locale, as per your comment. Thank you for your time and review.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

etudes-francaises.csl (new)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 ; « CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 ; Martin Fenner et al., « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, disponible en ligne : http://editor.citationstyles.org/searchByExample/ ; page consultée le 15 décembre 2012.
Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, vol. VI, nᵒ 1, 2019, p. 28, disponible en ligne : 10.1038/s41597-019-0031-8.
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », dans Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.

@bwiernik bwiernik merged commit f4eee59 into citation-style-language:master Mar 17, 2024
1 check passed
@bwiernik
Copy link
Member

Thanks!

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Mar 17, 2024
@loup-brun
Copy link
Contributor Author

Thank you! 😊

@loup-brun loup-brun deleted the csl-etudes-francaises branch March 18, 2024 14:17
@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants