-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(natives/ped): add SetPedPhonePaletteIdx #993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, this replaces a native, therefor the old native file should be removed. Ideally, an alias pointing to the old native name should be added as well since that's standard.
For x reason when searching it on my visual studio code, couldn't find it |
Should be good |
I removed the _ from the aliases since this native didn't has a name before |
Hey @4mmonium srry to ping you but any news for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK, but I'd prefer if you used an enum
rather than passing it as a string
for hash table (key-value pair tables) lookup. Check my comment, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, merging, thank you!
For js & c# examples i'm not sure at all, someone have to review it to be sure. Close the issue #989