Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated EG lists with Signal URLs #114

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Updated EG lists with Signal URLs #114

merged 1 commit into from
Jan 19, 2017

Conversation

sneft
Copy link
Collaborator

@sneft sneft commented Jan 19, 2017

No description provided.

@sneft sneft merged commit 9f28c35 into citizenlab:master Jan 19, 2017
@@ -153,3 +153,5 @@ https://twitter.com/ikhwanweb,FEXP,Free expression and media freedom,2014-04-15,
https://twitter.com/muhammadmorsi,FEXP,Free expression and media freedom,2014-04-15,citizenlab,
https://www.facebook.com/ikhwanweb.official,FEXP,Free expression and media freedom,2014-04-15,citizenlab,
https://www.alaraby.co.uk,FEXP,Free expression and media freedom,2016-10-23,OONI,
https://whispersystems.org,COMT,Communication Tools,2017-01-19,citizenlab,
http://textsecure-service-ca.whispersystems.org,COMT,Communication Tools,2017-01-19,citizenlab,Used by Signal desktop,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This service appears to not be listening on port 80, but only on 443 (you should use https instead of HTTP)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row 157 has an extra comma at the end, which is breaking some parsers (GitHub's included).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually adding this URL to confirm middlebox blocking - I've anecdotally seen the http version blocked by not https, so I'm not actually expecting a legit response from that server. Adding both to be sure.

Fixed comma, thanks @jdcc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sneft sorry only now read the comment here. I see your point. You mean that some HTTP proxy is intercepting the HTTP request and returning some blockpage on that? That would be interesting and I guess it's something worthwhile to test for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants