Relax required ruby version #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change restricted the required ruby version for this project to 3.0.3 or above. We have a few projects running on 2.7 and notably the design-system tests against both 2.7 and 3. Limiting the version to 3 prevents us from using the new version in these contexts. The rubocop docs for TargetRubyVersion suggest that this respects the project value if this is unset: > Otherwise, RuboCop will then check your project for a series of files where the version may be specified already. The files that will be looked for are .ruby-version, Gemfile.lock, and *.gemspec. If Gemspec file has an array for required_ruby_version, the lowest version will be used. If none of the files are found a default version value will be used. https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version As the ruby version is a project specific thing it makes sense to defer to the project rather than explicitly setting this in shared rules. This change removes `TargetRubyVersion` and widens the `required_ruby_version` again so we can continue to use this config against 2.7 versions of ruby.
|
I put it in because I had a project complaining I wasn't using Ruby 2.7. But, yes, I think you are correct, it was because the last version had This update should be version 5.0.1. Could you update the version file as well, and it needs tagged when merged. I wasn't sure anyone else was using this. I should have got a PR done before merging my last change. |
|
@davidrapson I've updated this as version 6. I've also updated rubocop as leaving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change restricted the required ruby version for this project to 3.0.3 or above. We have a few projects running on 2.7 and notably the design-system tests against both 2.7 and 3. Limiting the version to 3 prevents us from using the new version in these contexts.
The rubocop docs for TargetRubyVersion suggest that this respects the project value if this is unset:
https://docs.rubocop.org/rubocop/configuration.html#setting-the-target-ruby-version
As the ruby version is a project specific thing it makes sense to defer to the project rather than explicitly setting this in shared rules.
This change removes
TargetRubyVersionand widens therequired_ruby_versionagain so we can continue to use this config against 2.7 versions of ruby.Shout if I've misunderstood the intent of the original change.