Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Release 1.4) Enhancing Boot Notification Service/Handler tests #223

Merged

Commits on Aug 12, 2024

  1. enhancing boot notification service tests: adding missing "await" cal…

    …ls in Configuration module
    Venus Yu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6d18a17 View commit details
    Browse the repository at this point in the history
  2. enhancing boot notification service tests: updating boot servivce con…

    …structor to take in a cache + logger to support some of the boot notification handler functionality that was moved into the service
    Venus Yu committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b881bae View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. enhancing boot notification service tests: refactoring more functiona…

    …lity out of Configuration module's BootNotification handler to BootNotificationService + DeviceModelService to prepare for unit tests
    Venus Yu committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0be6e4d View commit details
    Browse the repository at this point in the history
  2. enhancing boot notification service tests: adding tests for BootNotif…

    …icationService's "cacheChargerActionsPermissions" method
    Venus Yu committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0e244b8 View commit details
    Browse the repository at this point in the history
  3. enhancing boot notification service tests: adding tests for BootNotif…

    …icationService's "triggerGetBaseReport" method
    Venus Yu committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c0ed881 View commit details
    Browse the repository at this point in the history
  4. enhancing boot notification service tests: removing unneeded commente…

    …d code in DeviceModelService
    Venus Yu committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    71b3324 View commit details
    Browse the repository at this point in the history
  5. enhancing boot notification service tests: fixing build issues with B…

    …ootNotificationService test
    Venus Yu committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    032314e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. enhancing boot notification service tests: updating condition to trig…

    …ger set variables if pendingBootSetVariables.length > 0, rather than > 1
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d7e2e9f View commit details
    Browse the repository at this point in the history
  2. enhancing boot notification service tests: fixing name of helper vari…

    …able from bootWithRejectedVariables to doNotBootWithRejectedVariables for clarity
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    164e26a View commit details
    Browse the repository at this point in the history
  3. enhancing boot notification service tests: rename from executeSetVari…

    …ablesActionsAfterBoot to executeSetVariablesAfterBoot for brevity
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7a08342 View commit details
    Browse the repository at this point in the history
  4. enhancing boot notification service tests: undoing some condition sim…

    …plifications
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2cc3d48 View commit details
    Browse the repository at this point in the history
  5. enhancing boot notification service tests: reverting pulling out of s…

    …et variables since it's not as easy to do as initially thought
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a116183 View commit details
    Browse the repository at this point in the history
  6. enhancing boot notification service tests: removing unused imports fr…

    …om DeviceModelService
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b128763 View commit details
    Browse the repository at this point in the history
  7. enhancing boot notification service tests: removing maxCachingSeconds…

    … as a constructor argument for BootNotificationService and instead passing it in to the relevant methods that need it + moving more cache-related calls back into the module since they're not relevant to the methods they were put into
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3d85952 View commit details
    Browse the repository at this point in the history
  8. enhancing boot notification service tests: removing maxCachingSeconds…

    … as a constructor argument from remaining files + adding more comments
    Venus Yu committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f2da404 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. enhancing boot notification service tests: removing unnecessary added…

    … awaits
    Venus Yu committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4537fda View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'refs/heads/rc-1.4.0' into feature/enhancing-boot-notifi…

    …cation-service-tests
    
    # Conflicts:
    #	03_Modules/Configuration/test/module/BootNotificationService.test.ts
    Venus Yu committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b8dbe79 View commit details
    Browse the repository at this point in the history