Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Universal Analytics #10

Merged
merged 11 commits into from Apr 30, 2016
Merged

Conversation

johngroves
Copy link

Adds support for Google Universal Analytics.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 99.248% when pulling dccfb59 on johngroves:master into ed146c4 on citruspi:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 99.248% when pulling f113bc0 on johngroves:master into ed146c4 on citruspi:master.

@johngroves
Copy link
Author

Passing here: https://semaphoreci.com/johngroves/flask-analytics/branches/master/builds/1 do you know what is causing the build to fail in Semaphore?

@minhoryang
Copy link

poke?

@citruspi
Copy link
Owner

@johngroves Nope, and the fact that the build fails on Semaphore without providing any output makes me slightly less inclined to trust the Semaphore results.

screen shot 2016-04-30 at 5 01 56 pm

I pulled down the branch and ran the tests successfully on Python 2.7.9 and Python 3.5.0.

(citruspi-Flask-Analytics)$ python --version
Python 2.7.9
(citruspi-Flask-Analytics)$ nosetests -v                   
test_all (test_app.TestAnalytics) ... ok
test_boostrap (test_app.TestAnalytics) ... ok
test_chartbeat (test_app.TestAnalytics) ... ok
test_disabled (test_app.TestAnalytics) ... ok
test_gauges (test_app.TestAnalytics) ... ok
test_google_classic (test_app.TestAnalytics) ... ok
test_google_universal (test_app.TestAnalytics) ... ok
test_gosquared (test_app.TestAnalytics) ... ok
test_none (test_app.TestAnalytics) ... ok
test_piwik (test_app.TestAnalytics) ... ok

----------------------------------------------------------------------
Ran 10 tests in 0.130s

OK
(citruspi-Flask-Analytics) $ python --version
Python 3.5.0
(citruspi-Flask-Analytics) $ nosetests -v    
test_all (test_app.TestAnalytics) ... ok
test_boostrap (test_app.TestAnalytics) ... ok
test_chartbeat (test_app.TestAnalytics) ... ok
test_disabled (test_app.TestAnalytics) ... ok
test_gauges (test_app.TestAnalytics) ... ok
test_google_classic (test_app.TestAnalytics) ... ok
test_google_universal (test_app.TestAnalytics) ... ok
test_gosquared (test_app.TestAnalytics) ... ok
test_none (test_app.TestAnalytics) ... ok
test_piwik (test_app.TestAnalytics) ... ok

----------------------------------------------------------------------
Ran 10 tests in 0.106s

OK

I think I'm comfortable merging this in and I'll probably end up removing Semaphore CI integration if I can't get it to work properly.

@citruspi citruspi merged commit 09c60e6 into citruspi:master Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants