Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_all has different behavior when supplying an id instead of an object #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reidmorrison
Copy link

This PR reproduces an issue where MultiTenant.with(account) has different behavior from MultiTenant.with(account.id) when calling delete_all or update_all.

Is it expected for the behavior to differ, or should we go ahead and remove the following 2 lines in order to make the behavior consistent for delete_all and update_all?
https://github.com/citusdata/activerecord-multi-tenant/blob/master/lib/activerecord-multi-tenant/relation_extension.rb#L8
And
https://github.com/citusdata/activerecord-multi-tenant/blob/master/lib/activerecord-multi-tenant/relation_extension.rb#L20

@reidmorrison
Copy link
Author

@microsoft-github-policy-service agree company="Salesloft"

@reidmorrison
Copy link
Author

@reidmorrison please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Salesloft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant