Fix TypeError: Cannot visit Arel::SelectManager when executing a subquery with Arel #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add visit_Arel_SelectManager to MultiTenant::ArelVisitorsDepthFirst in reference to https://github.com/rails/rails/blob/1b3fc3c82e36a1c5f19f174e318166a11bd0b301/activerecord/lib/arel/visitors/to_sql.rb#L358-L361
|
@microsoft-github-policy-service agree company="ASHITA-TEAM" |
serprex
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing a subquery using Arel, a
TypeError: Cannot visit Arel::SelectManageris raised if Arel::SelectManager is called internally.To fix this error, I have added a visit_Arel_SelectManager to arel_visitors_depth_first.rb and test. The implementation is based on https://github.com/rails/rails/blob/f6918a5b5d0b8c3a700513c2624cc195e0a78d14/activerecord/lib/arel/visitors/to_sql.rb#L358-L361