-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jobs to test builds on different distros #6499
Conversation
Btw are those tests run in parallel to each other ? If not, that would affect development velocity very badly. |
https://github.com/citusdata/citus/actions/runs/3489359842 |
bdfd625
to
4692339
Compare
53f3c7a
to
bbad460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
This PR adds 22 more jobs; 5 x 3 for rpm based distros, which is nice, and only 6 for deb based distros. Are we sure that we're testing deb based ones for all supported pg versions ?
-
Also seeing lots of such warnings, can we fix them ? (as in https://github.com/citusdata/citus/actions/runs/3530829173)
- For those gcc warnings, are we sure that we're using the correct gcc version (as you discussed with @JelteF in Teams chat) ?
(Btw this really looks good overall and I think we're very close to merge :) )
|
|
You're right. I changed to add all versions of Postgres for deb based distros now |
a0b65ed
to
d64abe7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thank you for adding those jobs to Citus to early detect build time issues / before it's time to do a release 🚀.
Here is a checklist before merging, feel free to click check-mark symbols on each item as you move forward:
- Now it's time to get in touch with people in engine chat to ask for help to get those build warnings fixed (to be able to merge this PR)
- Please squash the commits before merging.
- After merging the PR into main, please backport this at least to release-11.0 / release-11.1 branches (and optionally to release 10.2 too) so that we can early detect build-time problems / before doing a patch release for those versions.
Those versions of Citus are still actively supported and hence it's quite likely that we might want to release new packages for them at some point.
61877a8
to
eb7fa64
Compare
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
eb7fa64
to
c82b7aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working functionality with several comments for increasing readability and maintainability.
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
With this PR, citus code will be tested in all packaging environments. Sometimes, there can be compile errors which blocks packaging and in this case unplanned delays may occur. By testing the code in packaging environments, I'm aiming to detect any compilation errors before packaging. Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
With this PR, citus code will be tested in all packaging environments. Sometimes, there can be compile errors which blocks packaging and in this case unplanned delays may occur. By testing the code in packaging environments, I'm aiming to detect any compilation errors before packaging. Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
With this PR, citus code will be tested in all packaging environments. Sometimes, there can be compile errors which blocks packaging and in this case unplanned delays may occur. By testing the code in packaging environments, I'm aiming to detect any compilation errors before packaging. Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
With this PR, citus code will be tested in all packaging environments. Sometimes, there can be compile errors which blocks packaging and in this case unplanned delays may occur. By testing the code in packaging environments, I'm aiming to detect any compilation errors before packaging. Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com>
With this PR, citus code will be tested in all packaging environments.
Sometimes, there can be compile errors which blocks packaging and in this case unplanned delays may occur.
By testing the code in packaging environments, I'm aiming to detect any compilation errors before packaging.