Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use citus_shard_sizes in citus_tables #7018

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

halilozanakgul
Copy link
Contributor

@halilozanakgul halilozanakgul commented Jun 21, 2023

DESCRIPTION: Improves citus_tables view performance
DESCRIPTION: Fixes shard size bug with too many shards

Fixes #7019
Fixes #7020

This PR updates citus_tables view to use citus_shard_sizes function, instead of citus_total_relation_size to improve performance.

@halilozanakgul halilozanakgul marked this pull request as draft June 21, 2023 08:20
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #7018 (32c52e2) into main (719d92c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #7018   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         273      273           
  Lines       58515    58527   +12     
=======================================
+ Hits        54621    54633   +12     
  Misses       3894     3894           

@halilozanakgul halilozanakgul marked this pull request as ready for review June 26, 2023 13:26
Copy link
Member

@marcocitus marcocitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and even at very small scale it seems at least 2x faster for me.

@halilozanakgul halilozanakgul merged commit 613cced into main Jul 5, 2023
77 checks passed
@halilozanakgul halilozanakgul deleted the improve_citus_tables_size_col branch July 5, 2023 08:40
halilozanakgul added a commit that referenced this pull request Jul 14, 2023
This PR combines the relevant parts of #7003, #7018 and the PR that
backports those changes to 11.3, #7050 to merge into the 11.3 release
branch.

This PR backports the changes to 11.3 release branch, there is another
PR, #7062, for 12.0 release branch and one, #7050, for main branch.

The commits are:
613cced
772d194
halilozanakgul added a commit that referenced this pull request Jul 14, 2023
This PR moves `citus_shard_sizes` changes from #7003, and #7018 to a new
Citus version 11.3-2

This PR backports the changes to 12.0 release branch, there is another
PR, #7051 for 11.3 release branch, and one, #7050, for main branch.
halilozanakgul added a commit that referenced this pull request Jul 14, 2023
… version (#7050)

This PR moves `citus_shard_sizes` changes from #7003, and #7018 to into
a new Citus version, 11.3-2
@YMikheev
Copy link

Hello.
Please tell me in with version of Citus this bug is fixed?
12.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants