-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use citus_shard_sizes in citus_tables #7018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
460f9ee
to
a90fa5f
Compare
Codecov Report
@@ Coverage Diff @@
## main #7018 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 273 273
Lines 58515 58527 +12
=======================================
+ Hits 54621 54633 +12
Misses 3894 3894 |
marcocitus
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, and even at very small scale it seems at least 2x faster for me.
8989247
to
32c52e2
Compare
This was referenced Jul 12, 2023
halilozanakgul
added a commit
that referenced
this pull request
Jul 14, 2023
This PR combines the relevant parts of #7003, #7018 and the PR that backports those changes to 11.3, #7050 to merge into the 11.3 release branch. This PR backports the changes to 11.3 release branch, there is another PR, #7062, for 12.0 release branch and one, #7050, for main branch. The commits are: 613cced 772d194
halilozanakgul
added a commit
that referenced
this pull request
Jul 14, 2023
Hello. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Improves citus_tables view performance
DESCRIPTION: Fixes shard size bug with too many shards
Fixes #7019
Fixes #7020
This PR updates citus_tables view to use citus_shard_sizes function, instead of citus_total_relation_size to improve performance.