-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve citus_shard_sizes performance in release-11.3 #7051
Improve citus_shard_sizes performance in release-11.3 #7051
Conversation
Codecov Report
@@ Coverage Diff @@
## release-11.3 #7051 +/- ##
=================================================
+ Coverage 74.70% 93.25% +18.54%
=================================================
Files 687 269 -418
Lines 131591 57498 -74093
=================================================
- Hits 98305 53619 -44686
+ Misses 33286 3879 -29407 |
97bebce
to
a90a3a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Some notes:
- make sure your C changes are identical to the ones in main branch
- would be good to ask another person from the team if it's okay we're backporting two commits in one
- update the description to say that this PR actually backports to 11.3, and the PR to main branch will also include 11.3-2 in the upgrade/downgrade path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested altering the extension locally, both upgrade and downgrade - it worked fine. But we need to add that to our tests.
i.e. We also need to add ALTER EXTENSION
tests to multi_extension.sql
file, similar to the other lines in that file. Below is an example for 11.2-2--11.3-1
-- Snapshot of state at 11.2-2
ALTER EXTENSION citus UPDATE TO '11.2-2';
SELECT * FROM multi_extension.print_extension_changes();
-- Test downgrade to 11.2-2 from 11.3-1
ALTER EXTENSION citus UPDATE TO '11.3-1';
ALTER EXTENSION citus UPDATE TO '11.2-2';
-- Should be empty result since upgrade+downgrade should be a no-op
SELECT * FROM multi_extension.print_extension_changes();
-- Snapshot of state at 11.3-1
ALTER EXTENSION citus UPDATE TO '11.3-1';
SELECT * FROM multi_extension.print_extension_changes();
a90a3a7
to
aca4adb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks.
Please provide a detailed commit description when you merge.
This PR combines the relevant parts of #7003, #7018 and the PR that backports those changes to 11.3, #7050 to merge into the 11.3 release branch.
This PR backports the changes to 11.3 release branch, there is another PR, #7062, for 12.0 release branch and one, #7050, for main branch.