-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Grant Role support from non-main db #7404
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7404 +/- ##
==========================================
- Coverage 89.60% 89.03% -0.58%
==========================================
Files 282 282
Lines 60323 60347 +24
Branches 7512 7517 +5
==========================================
- Hits 54051 53727 -324
- Misses 4117 4416 +299
- Partials 2155 2204 +49 |
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're close to merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In summary, let's merge those two one-liner fixes in separate two PRs and then we're good to merge this:
#7404 (comment)
#7404 (comment)
Let's merge #7517 and then rebase this onto main. Then we can finally merge this one. |
Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
DESCRIPTION: Adds support for distributed role-membership management commands from the databases where Citus is not installed (
GRANT <role> TO <role>
)This PR also refactors the code-path that allows executing some of the node-wide commands so that we use send deparsed query string to other nodes instead of the
queryString
passed into utility hook.Hence fixes #7448.