Add support for create / drop database propagation from non-main databases #7439
+355
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Jan 23, 2024
halilozanakgul
force-pushed
the
create_db_from_other_db
branch
from
5749675
to
570ed2a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7439 +/- ##
==========================================
- Coverage 89.59% 89.06% -0.54%
==========================================
Files 282 282
Lines 60354 60369 +15
Branches 7517 7521 +4
==========================================
- Hits 54076 53766 -310
- Misses 4126 4401 +275
- Partials 2152 2202 +50 |
halilozanakgul
force-pushed
the
create_db_from_other_db
branch
from
570ed2a
to
4a4db7c
Compare
JelteF
reviewed
Jan 31, 2024
JelteF
reviewed
Jan 31, 2024
JelteF
requested changes
Jan 31, 2024
JelteF
requested changes
Jan 31, 2024
onurctirtir
reviewed
Feb 1, 2024
onurctirtir
reviewed
Feb 1, 2024
onurctirtir
reviewed
Feb 1, 2024
Did we agree on calling out other databases as "non-main dbs" in user-facing errors / docs, or should we instead say What do you think @halilozanakgul, @JelteF? |
halilozanakgul
force-pushed
the
create_db_from_other_db
branch
from
4a4db7c
to
ffff54f
Compare
halilozanakgul
force-pushed
the
create_db_from_other_db
branch
from
ffff54f
to
822aadc
Compare
onurctirtir
changed the title
onurctirtir
force-pushed
the
create_db_from_other_db
branch
from
822aadc
to
146a685
Compare
onurctirtir
approved these changes
Feb 21, 2024
JelteF
reviewed
Feb 21, 2024
onurctirtir
force-pushed
the
create_db_from_other_db
branch
from
146a685
to
e0d0660
Compare
pushed again now |
JelteF
approved these changes
Feb 21, 2024
onurctirtir
added a commit
that referenced
this pull request
Feb 23, 2024
…ain dbs (#7532) When adding CREATE/DROP DATABASE propagation in #7240, luckily we've added EnsureSupportedCreateDatabaseCommand() check into deparser too just to be on the safe side. That way, today CREATE DATABASE commands from non-main dbs don't silently allow unsupported options. I wasn't aware of this when merging #7439 and hence wanted to add a test so that we don't mistakenly remove that check from deparser in future.
emelsimsek
pushed a commit
that referenced
this pull request
Mar 11, 2024
…bases (#7439) DESCRIPTION: Adds support for distributed `CREATE/DROP DATABASE ` commands from the databases where Citus is not installed --------- Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
emelsimsek
pushed a commit
that referenced
this pull request
Mar 11, 2024
…ain dbs (#7532) When adding CREATE/DROP DATABASE propagation in #7240, luckily we've added EnsureSupportedCreateDatabaseCommand() check into deparser too just to be on the safe side. That way, today CREATE DATABASE commands from non-main dbs don't silently allow unsupported options. I wasn't aware of this when merging #7439 and hence wanted to add a test so that we don't mistakenly remove that check from deparser in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Adds support for distributed
CREATE/DROP DATABASEcommands from the databases where Citus is not installed